Skip to content

Update ReactiveSwift to 4.0#107

Merged
tmspzz merged 3 commits intomasterfrom
reactiveswift-4.0
Jul 20, 2018
Merged

Update ReactiveSwift to 4.0#107
tmspzz merged 3 commits intomasterfrom
reactiveswift-4.0

Conversation

@ikesyo
Copy link
Member

@ikesyo ikesyo commented Jul 20, 2018

No description provided.

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to commit these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is in xcshareddata I think so.

Copy link
Member Author

@ikesyo ikesyo Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to commit these?

Copy link
Member Author

@ikesyo ikesyo Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. Without this we can not use the New Build System in Xcode 9.4 (in Xcode 10 the New Build System is the default so it will not be needed but the explictness should be good).

@tmspzz tmspzz merged commit eae2415 into master Jul 20, 2018
@tmspzz tmspzz deleted the reactiveswift-4.0 branch July 20, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants