Skip to content

feat(wren-ui): Mask OIDC web identity token field #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
douenergy merged 3 commits into from
Nov 28, 2025
Merged

feat(wren-ui): Mask OIDC web identity token field #2063

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a608fd
mask oidc token
douenergy Nov 28, 2025
e0cdabe
update setup connection
douenergy Nov 28, 2025
2486f85
Update wren-ui/src/hooks/useSetupConnectionDataSource.tsx
douenergy Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions wren-ui/src/apollo/server/services/projectService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const SENSITIVE_PROPERTY_NAME = new Set([
'privateKey',
'accessToken',
'clientSecret',
'webIdentityToken'
]);
export interface ProjectData {
displayName: string;
Expand Down
4 changes: 2 additions & 2 deletions wren-ui/src/components/pages/setup/dataSources/AthenaProperties.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ function AthenaOIDCFields(props: { isEditMode: boolean }) {
},
]}
>
<Input.TextArea
rows={3}
<Input.Password
placeholder="OAuth 2.0 access token or OpenID Connect ID token"
autoComplete="off"
/>
</Form.Item>

Expand Down
17 changes: 17 additions & 0 deletions wren-ui/src/hooks/useSetupConnectionDataSource.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,14 @@ export const transformFormToProperties = (
...properties,
...getDatabricksAuthentication(properties),
};
} else if (dataSourceType === DataSourceName.ATHENA) {
return {
...properties,
...getAthenaAuthentication(properties),
};
}


return {
...properties,
// remove password placeholder if user doesn't change the password
Expand Down Expand Up @@ -187,3 +193,14 @@ function getDatabricksAuthentication(properties: Record<string, any>) {
: properties?.accessToken,
};
}

function getAthenaAuthentication(properties: Record<string, any>) {
if (properties?.webIdentityToken) {
return {
webIdentityToken:
properties?.webIdentityToken === PASSWORD_PLACEHOLDER
? undefined
: properties?.webIdentityToken,
};
}
}