fix(dbt): add quote for the condition of relationship

[goldmedal]

• Always add the quotes for the identifier to avoid the case-sensitive issue and Unique character.
• To avoid returning nil, create an empty slice for the relationship.

Summary by CodeRabbit

• Bug Fixes
  • Improved compatibility by correctly quoting identifiers in relationship conditions, reducing errors with case-sensitive or reserved names across databases.
  • Standardized outputs to return empty lists when no relationships are found, avoiding nulls and preventing downstream parsing issues.
  • Enhanced reliability and predictability of relationship generation and extraction, resulting in more consistent results across projects.

[coderabbitai]

Walkthrough

Updated relationship condition strings to quote identifiers in converter logic and standardized returns to use empty slices instead of nil for relationship-related results. Added clarifying comments. All changes are confined to wren-launcher/commands/dbt/converter.go.

Changes

Cohort / File(s)	Summary
DBT relationship formatting and slice initialization wren-launcher/commands/dbt/converter.go	Quoted identifiers in relationship Condition strings (e.g., """."""). Initialized relationship-related slices as empty slices instead of nil in generateRelationships and extractRelationshipsFromTests. Added comments clarifying empty slice returns.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibble quotes around each name,
so fields and models play the same.
No nil burrows—lists instead,
tidy trails for what’s been read.
Thump-thump! The schema’s clean and neat,
a carrot-crisp, consistent treat. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit's high-level summary is enabled.
Title Check	✅ Passed	The title concisely summarizes the main change—adding quotes around relationship condition identifiers in the dbt converter—and follows conventional commit style.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/dbt-relationship

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58fc30a and 9884e1f.

📒 Files selected for processing (1)

• wren-launcher/commands/dbt/converter.go (4 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

wren-launcher/commands/dbt/converter.go (1)

wren-launcher/commands/dbt/wren_mdl.go (1)

• Relationship (58-64)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (go)

🔇 Additional comments (3)

wren-launcher/commands/dbt/converter.go (3)

548-556: LGTM! Proper identifier quoting for SQL compatibility.

The addition of double quotes around model and field names in the relationship condition correctly handles case-sensitive identifiers and special characters, which is essential for SQL compatibility across different database systems.

---

563-575: LGTM! Empty slice initialization improves API consistency.

Initializing unique as an empty slice instead of nil ensures consistent JSON serialization ([] instead of null) and prevents nil-related edge cases. The explanatory comment is helpful.

---

602-625: LGTM! Consistent implementation of identifier quoting and slice initialization.

Both changes in this function align with the earlier modifications:

• Empty slice initialization provides consistent JSON serialization behavior
• Quoted identifiers in the condition string ensure proper handling of case-sensitive and special character scenarios

The implementation is consistent across the codebase.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[douenergy]

Thanks @goldmedal