chore(wren-ai-service): fix add quotes

[cyyeh]

Summary by CodeRabbit

• Bug Fixes
  • Improved SQL identifier quoting to prevent collisions with common function and window terms (e.g., extract, date_trunc, sum, avg, rank, lag, lead, cast, coalesce). Identifiers matching these words are now safely quoted, reducing query failures and unexpected behavior across databases.
  • Enhances reliability when using column or table names that resemble SQL keywords, with no changes to the public API or configuration.

[coderabbitai]

Walkthrough

Adjusted internal SQL keyword classification in wren-ai-service/src/core/engine.py by removing several terms from the non-quoting keyword set, affecting how identifiers are quoted. No public APIs or control flow were changed.

Changes

Cohort / File(s)	Summary of Changes
SQL keyword classification wren-ai-service/src/core/engine.py	Updated is_sql_keyword logic: removed CTE and multiple function/window terms (e.g., EXTRACT, DATE_TRUNC, COUNT, OVER, CAST, COALESCE, etc.) from the non-quoting set so these tokens may now be quoted as identifiers. No API or control-flow changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• chore(wren-ai-service): improve add quotes #1913 — Also modifies SQL quoting logic in engine.py, reworking add_quotes/tokenization.
• chore(wren-ai-service): fix add quotes #1917 — Adjusts is_sql_keyword/quoting behavior in the same file.

Suggested labels

wren-ai-service

Suggested reviewers

• yichieh-lu

Poem

In rows and ranks I twitch my ear,
QUOTE or not? The path is clear.
EXTRACT hops back to identifier land,
CAST and COUNT now lend a hand.
I nibble tokens, soft and bright—
Less “keyword,” more “quoted” in moonlit byte. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7dbfde5 and ce1a260.

📒 Files selected for processing (1)

• wren-ai-service/src/core/engine.py (0 hunks)

💤 Files with no reviewable changes (1)

• wren-ai-service/src/core/engine.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: pytest
• GitHub Check: pytest
• GitHub Check: Analyze (go)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/ai-service/fix-add-quotes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.