chore(wren-ai-service): improve error handling

[cyyeh]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for SQL execution errors, ensuring consistent error messages and standardized return values.
  • Ensured that chart data is always processed as a dictionary, preventing issues with missing or invalid data.

[coderabbitai]

Walkthrough

The changes standardize error handling and data assignment in two components. In the SQL execution provider, error messages are now extracted, logged, and returned with a consistent empty dictionary for data on failure. In the chart service, the SQL data assignment is updated to always use a dictionary, defaulting to an empty one when no data is provided.

Changes

File(s)	Change Summary
wren-ai-service/src/providers/engine/wren.py	Refactored error handling in WrenUI.execute_sql to extract/log error messages, return empty dicts on failure, and include a correlation ID if present.
wren-ai-service/src/web/v1/services/chart.py	Updated ChartService.chart to assign sql_data as a dictionary, defaulting to {} if no data is present.

Poem

In the warren of code, we tidy the den,
Errors now logged, with messages when!
Empty dicts hop in, no None in sight,
Chart data’s consistent, the future is bright.
🐇 With each little fix, our service feels right!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46a6eba and b8edf02.

📒 Files selected for processing (2)

• wren-ai-service/src/providers/engine/wren.py (1 hunks)
• wren-ai-service/src/web/v1/services/chart.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: pytest
• GitHub Check: pytest
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (go)

🔇 Additional comments (5)

wren-ai-service/src/web/v1/services/chart.py (1)

134-134: Great defensive programming!

Using the or {} pattern ensures that sql_data will always be a dictionary, even when chart_request.data is None or falsy. This prevents potential "NoneType has no attribute" errors in downstream code that expects a dictionary.

wren-ai-service/src/providers/engine/wren.py (4)

65-70: Good improvement to error handling and logging

Extracting the error message once into a variable and adding proper error logging are excellent improvements. This makes debugging easier and the code more maintainable.

---

73-73: Consistent return type on error

Replacing what was likely None with an empty dictionary {} ensures consistent return types even in error cases. This aligns with the change in chart.py and prevents potential type errors downstream.

---

75-80: Improved error metadata structure

Using the extracted error message and updating the correlation_id extraction to navigate through the nested structure properly provides more reliable error information. The chained get() calls with default values ensure null safety.

---

86-86: Consistent error return type for timeout case

Changing from None to {} in the timeout exception handler maintains consistency with the other error handling improvements. This ensures that consumers of this API get predictable return types.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[imAsterSun]

approved