Skip to content

Conversation

@fredalai
Copy link
Contributor

@fredalai fredalai commented Mar 19, 2025

Description

  • Use rephrasedQuestion first
    • For asking a question/follow-up question, will use 'rephrasedQuestion' as the initial value for the question of the Add Question-SQL pair Modal
    • For clicking a Recommended question in a thread page, will use ‘question’ as the initial value for the question of the Add Question-SQL pair Modal

Summary by CodeRabbit

  • New Features
    • The modal interface for saving content now displays the most contextually relevant question text. When an updated version is available, it will be prioritized over the original version, providing clearer and more meaningful information during interactions. This enhancement improves the overall clarity and user experience when engaging with saved content features.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes modify the handling of the question parameter within the AnswerResult.tsx component. The update now prioritizes using threadResponse?.askingTask?.rephrasedQuestion if it is available, while falling back to the original question when it isn’t. The sql parameter remains unchanged. This adjustment refines the data passed to the onOpenSaveToKnowledgeModal function for contextual relevance.

Changes

File(s) Change Summary
wren-ui/.../AnswerResult.tsx Updated the call to onOpenSaveToKnowledgeModal by modifying the question value to first check for threadResponse?.askingTask?.rephrasedQuestion, with fallback.

Sequence Diagram(s)

sequenceDiagram
    participant AR as AnswerResult.tsx
    participant Modal as Knowledge Modal

    alt If rephrasedQuestion exists
        AR->>Modal: onOpenSaveToKnowledgeModal(rephrasedQuestion, sql)
    else
        AR->>Modal: onOpenSaveToKnowledgeModal(question, sql)
    end
Loading

Suggested labels

module/ui

Suggested reviewers

  • wwwy3y3

Poem

I’m a coding rabbit with a skip in my beat,
Hopping through changes, making code neat.
With rephrased questions and SQL in sight,
I nibble on updates from morning to night.
A joyful leap for a modal so bright!
🐇💻 Happy coding, let changes take flight!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bad3d77 and a0a76bc.

📒 Files selected for processing (1)
  • wren-ui/src/components/pages/home/promptThread/AnswerResult.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Base automatically changed from feat/reasoning-ui to main March 19, 2025 03:11
@fredalai fredalai force-pushed the feat/sql-pairs-question branch from 5e689e0 to a0a76bc Compare March 19, 2025 03:12
@onlyjackfrost onlyjackfrost merged commit b53f111 into main Mar 19, 2025
7 of 8 checks passed
Copy link
Contributor

@andreashimin andreashimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onlyjackfrost onlyjackfrost deleted the feat/sql-pairs-question branch March 19, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants