Open
Conversation
Load Unit Test
Real3Lee
requested review from
CluckRookie,
SayaZhang,
SeisSerenata and
goldmermaid
as code owners
SayaZhang
reviewed
Mar 4, 2024
|
|
||
| class TestExtractHTMLOp(unittest.TestCase): | ||
| def test_extract_html_op_with_url(self): | ||
| extract_op = ExtractHTMLOp("test_extract") |
Collaborator
There was a problem hiding this comment.
shall we init the function in the class?
e.g. self.extract_op = ExtractHTMLOp("test_splitter")
SayaZhang
reviewed
Mar 4, 2024
| return_value="<html><body><p>Hello World</p></body></html>", | ||
| ): | ||
| output = extract_op([node]) | ||
| self.assertEqual(len(output), 1) |
Collaborator
There was a problem hiding this comment.
shall we add a new line here?
def test_call_with_empty_node(self, mock_read_file):
# arrange
nodes = []
# act
output_nodes = self.extract_txt_op(nodes)
# assert
mock_read_file.assert_not_called()
self.assertEqual(len(output_nodes), 0)
SayaZhang
reviewed
Mar 4, 2024
| self.assertEqual(output[0].value_dict["text"], "Hello World") | ||
|
|
||
| def test_extract_html_op_with_filename(self): | ||
| extract_op = ExtractHTMLOp("test_extract") |
SayaZhang
reviewed
Mar 4, 2024
| output = extract_op([node]) | ||
| self.assertEqual(len(output), 1) | ||
| self.assertEqual(output[0].value_dict["text"], "") | ||
|
|
Collaborator
There was a problem hiding this comment.
nit: it might be worth adding two more unit tests to test with more than one node and no node. https://medium.com/@samarthgvasist/parameterized-unit-testing-in-python-9be82fa7e17f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit Test For Load