Fix: move import to class __init__ and add RecursiveCharacterSplitter#141
Merged
SayaZhang merged 10 commits intoCambioML:mainfrom Feb 3, 2024
Merged
Fix: move import to class __init__ and add RecursiveCharacterSplitter#141SayaZhang merged 10 commits intoCambioML:mainfrom
SayaZhang merged 10 commits intoCambioML:mainfrom
Conversation
CambioML
changed the title
CambioML
reviewed
Jan 25, 2024
| return output_nodes | ||
|
|
||
| def recursive_splitter(self, text: str, separators: List[str]) -> List[str]: | ||
| """Split incoming text and return chunks.""" |
Collaborator
There was a problem hiding this comment.
nit: can we add missing Args and Returns in the docstring. Meanwhile, could you please add a bit more comment regarding what is a recursive splitter and how it works to ease the review. Sorry. I am not on top of how it works.
CambioML
approved these changes
Feb 1, 2024
| """Extract txt Flow Constructor.""" | ||
| super().__init__() | ||
| self._extract_txt_op = ExtractTxtOp(name="extract_txt_op") | ||
| self._process_txt_op = ProcessTxtOp(name="process_txt_op") |
Collaborator
There was a problem hiding this comment.
qq: I thought ProcessTxtOp is used re to split extracted txt string. What is the difference between the self._process_txt_op and self._split_op?
uniflow/op/extract/load/html_op.py
Outdated
| resp = requests.get(url=value_dict["url"], timeout=300) | ||
| resp = self._requests_client.get(url=value_dict["url"], timeout=300) | ||
| text = resp.text | ||
| else: |
Collaborator
There was a problem hiding this comment.
Can we update this else to check filename and then add a else case to log regarding a specific extract format is not supported. This should help improved the readability.
CambioML
approved these changes
Feb 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.