Add the v3 audit and cleanup plan bundle - #175
Conversation
Capture the prioritized cleanup, architecture, fork, and motion work with executable verification gates.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| > **Executor instructions**: Follow this plan exactly and update only this | ||
| > plan's status row in `advisor-plans/README.md` when done. Delete files with | ||
| > `trash` or a patch, never `rm`. Stop on any STOP condition. |
There was a problem hiding this comment.
trash availability assumption
Plans 002, 003, and 007 all instruct executors to delete files with trash rather than rm. trash (the trash-cli / macos-trash utility) is not present by default on most Linux CI runners or fresh macOS shells. An executor who follows the instruction literally on a system without it will get a command not found error mid-plan. The fallback option (or a patch) is mentioned but not explained — git rm achieves a safe, reversible deletion that is universally available and leaves a clean diff for review. Consider naming it explicitly, e.g. `git rm <file>` or `trash <file>` (requires `trash-cli` / `brew install trash`).
Prompt To Fix With AI
This is a comment left during a code review.
Path: advisor-plans/002-retire-sanity-port-tooling.md
Line: 5
Comment:
**`trash` availability assumption**
Plans 002, 003, and 007 all instruct executors to delete files with `trash` rather than `rm`. `trash` (the `trash-cli` / `macos-trash` utility) is not present by default on most Linux CI runners or fresh macOS shells. An executor who follows the instruction literally on a system without it will get a `command not found` error mid-plan. The fallback option (`or a patch`) is mentioned but not explained — `git rm` achieves a safe, reversible deletion that is universally available and leaves a clean diff for review. Consider naming it explicitly, e.g. `` `git rm <file>` or `trash <file>` (requires `trash-cli` / `brew install trash`) ``.
How can I resolve this? If you propose a fix, please make it concise.
| | [003](003-remove-unreachable-v3-residue.md) | Remove unreachable v3 modules and artifacts | P1 | S | none | TODO | | ||
| | [004](004-remove-design-switchboards.md) | Remove the dormant icon and shape switchboards | P1 | M | 003 | TODO | | ||
| | [005](005-deepen-site-profile.md) | Put fork identity behind one Site Profile interface | P1 | L | none | TODO | | ||
| | [006](006-gate-optional-operator-stack.md) | Make the Operator Stack optional per site | P1 | L | 005 | TODO | | ||
| | [007](007-document-and-verify-forks.md) | Document and verify the supported fork workflow | P1 | M | 002, 004, 005, 006 | TODO | | ||
|
|
||
| Status values: `TODO`, `IN PROGRESS`, `DONE`, `BLOCKED: <reason>`, or | ||
| `REJECTED: <reason>`. | ||
|
|
There was a problem hiding this comment.
The dependency column for plan 005 correctly shows none, but the Dependency Notes section says "executing it after the deletion plans keeps its identity inventory and diff smaller." An executor reading only the table would reasonably start plan 005 in parallel with 001–003, producing a larger and noisier diff than intended. Consider adding a parenthetical to the table cell (e.g. none (run after 003/004 preferred)) or promoting the recommendation to a Note callout directly above the table, so it is visible without scrolling past the dependency notes.
Prompt To Fix With AI
This is a comment left during a code review.
Path: advisor-plans/README.md
Line: 20-28
Comment:
**Soft execution ordering for plan 005 not signaled in the table**
The dependency column for plan 005 correctly shows `none`, but the Dependency Notes section says "executing it after the deletion plans keeps its identity inventory and diff smaller." An executor reading only the table would reasonably start plan 005 in parallel with 001–003, producing a larger and noisier diff than intended. Consider adding a parenthetical to the table cell (e.g. `none (run after 003/004 preferred)`) or promoting the recommendation to a `Note` callout directly above the table, so it is visible without scrolling past the dependency notes.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
The plan bundle has moved to GitHub Issues, which is this repository's source of truth for executable work:
All issues are labeled |
1 participant
Summary
devarchitecture and PRs Smooth article map motion and desktop progress #170 through Refine mobile article map expansion #172, including static/PPR admin security, current Media and Photos routes, zsh-safe profile restoration, keyboard-safe contribution cells, and mid-exit preview reversalScope
This PR is plan-only. It does not remove runtime code, alter production behavior, access provider data, or change hosted infrastructure. Every active plan remains
TODOuntil implemented and verified separately.Verification
pnpm test:unit: 107 files passed, 1,007 tests passedgit diff --check origin/devGreptile Summary
This is a plan-only PR adding 13 Markdown files — seven advisor plans covering test consolidation, Sanity tooling retirement, v3 residue removal, design switchboard cleanup, a Site Profile interface, optional Operator Stack gating, and fork documentation, plus four motion plans for explicit route state, interruptible preview cards, and instant keyboard actions in the lightbox and article map. No runtime code, production behavior, or hosted infrastructure is changed.
plans/format, reference the design-language keyboard-instant rule, and account for the phone pointer sequences accepted in PRs Smooth article map motion and desktop progress #170 and Refine mobile article map expansion #172.Risk: HIGHwith a hard dependency on the committed Site Profile from plan 005.Confidence Score: 5/5
Safe to merge — no runtime code, production behavior, or infrastructure is changed; every file is a Markdown plan document.
All 13 changed files are planning documents with no effect on running code. The plans are internally consistent, carry explicit drift checks and STOP conditions, and the dependency ordering in the index matches the stated rationale. The two observations are about plan usability and have no impact on the current codebase.
advisor-plans/006-gate-optional-operator-stack.md warrants careful reading before execution — it is correctly marked Risk: HIGH and gates ~80 files of provider initialization behind the Site Profile.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["001 - Stabilize unit-test baseline\n(Priority: P1, Effort: M)"] B["002 - Retire Sanity port tooling\n(Priority: P1, Effort: S)"] C["003 - Remove unreachable v3 residue\n(Priority: P1, Effort: S)"] D["004 - Remove design switchboards\n(Priority: P1, Effort: M)"] E["005 - Deepen Site Profile\n(Priority: P1, Effort: L)"] F["006 - Gate optional Operator Stack\n(Priority: P1, Effort: L, Risk: HIGH)"] G["007 - Document and verify forks\n(Priority: P1, Effort: M)"] M1["plans/005 - Explicit route motion state"] M2["plans/006 - Interruptible preview cards"] M3["plans/007 - Instant lightbox keyboard"] M4["plans/008 - Instant article-map keyboard"] C --> D E --> F B --> G D --> G E --> G F --> G A:::independent B:::independent C:::independent E:::independent M1:::motion M2:::motion M3:::motion M4:::motion classDef independent fill:#d4edda,stroke:#28a745 classDef motion fill:#cce5ff,stroke:#004085%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A["001 - Stabilize unit-test baseline\n(Priority: P1, Effort: M)"] B["002 - Retire Sanity port tooling\n(Priority: P1, Effort: S)"] C["003 - Remove unreachable v3 residue\n(Priority: P1, Effort: S)"] D["004 - Remove design switchboards\n(Priority: P1, Effort: M)"] E["005 - Deepen Site Profile\n(Priority: P1, Effort: L)"] F["006 - Gate optional Operator Stack\n(Priority: P1, Effort: L, Risk: HIGH)"] G["007 - Document and verify forks\n(Priority: P1, Effort: M)"] M1["plans/005 - Explicit route motion state"] M2["plans/006 - Interruptible preview cards"] M3["plans/007 - Instant lightbox keyboard"] M4["plans/008 - Instant article-map keyboard"] C --> D E --> F B --> G D --> G E --> G F --> G A:::independent B:::independent C:::independent E:::independent M1:::motion M2:::motion M3:::motion M4:::motion classDef independent fill:#d4edda,stroke:#28a745 classDef motion fill:#cce5ff,stroke:#004085Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "docs: reconcile v3 audit plans" | Re-trigger Greptile