-
Notifications
You must be signed in to change notification settings - Fork 12
Implement checks for message length before sending #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MattyTheHacker
wants to merge
15
commits into
main
Choose a base branch
from
message-length-checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bea5cce
Fix message max length error
MattyTheHacker 0137e68
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] 29c56e2
Merge branch 'main' into message-length-checks
MattyTheHacker b91e496
Fix for list command
MattyTheHacker 482abf2
Improve list-all
MattyTheHacker 3272d68
Merge main into message-length-checks
automatic-pr-updater[bot] f53da7a
Fixes
MattyTheHacker 4fd6c65
Merge main into message-length-checks
automatic-pr-updater[bot] 7384144
Merge main into message-length-checks
automatic-pr-updater[bot] 553ada0
Merge main into message-length-checks
automatic-pr-updater[bot] 12c15cc
Merge main into message-length-checks
automatic-pr-updater[bot] e27e6ca
Merge main into message-length-checks
automatic-pr-updater[bot] 467a14b
Merge main into message-length-checks
automatic-pr-updater[bot] 445cdbd
Merge main into message-length-checks
automatic-pr-updater[bot] e7af57e
Merge main into message-length-checks
automatic-pr-updater[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be sent to the user? Or just a logged message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was debating that, tbh I have half a mind to say it's not needed at all. not too bothered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yh lets get rid of it