test: run pytket on guppy_opt tests, measure (very limited) success #1250
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
==========================================
+ Coverage 79.12% 79.46% +0.34%
==========================================
Files 160 160
Lines 20421 20378 -43
Branches 19489 19446 -43
==========================================
+ Hits 16158 16194 +36
+ Misses 3280 3201 -79
Partials 983 983
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acl-cqc
force-pushed
the
acl/guppy_opt_tests
branch
from
8a46b49 to
1a3d20d
Compare
acl-cqc
force-pushed
the
acl/guppy_opt_tests
branch
from
1a3d20d to
68c22b4
Compare
acl-cqc
changed the title
tket-qsystem/tests/guppy_opt.rs
Outdated
| #[case::ranges(guppy_ranges(), [ | ||
| ("tket.quantum.QAlloc", 4), ("tket.quantum.MeasureFree", 4), ("tket.quantum.H", 2), ("tket.quantum.CX", 2) | ||
| ], [ | ||
| ("TKET1.tk1op", 1), ("tket.quantum.QAlloc", 1), ("tket.quantum.H", 1), ("tket.quantum.MeasureFree", 1) |
There was a problem hiding this comment.
Haven't looked at what's going on here with this TKET1 op
acl-cqc
force-pushed
the
acl/guppy_opt_tests
branch
from
63baf80 to
b9b004b
Compare
When the TKET_C_API_PATH env var is set, `tket1-passes` looks for the shared library in the given path rather than trying to build it by itself. We use the to be able to cache a single artifact and share it around. Although the env var is set globally, we weren't calling the install action in a couple jobs. This should fix the errors seen in #1250
| #[case::simple_cx(guppy_simple_cx(), [ | ||
| ("tket.quantum.QAlloc", 2), ("tket.quantum.CX", 2), ("tket.quantum.MeasureFree", 2) | ||
| ])] | ||
| #[should_panic = "xfail"] |
There was a problem hiding this comment.
Note this homebrew xfail mechanism, which allows the test to fail but only if the gate counts are exactly as expected in the test header.
Could do the same to flatten_guppy too?
| #[case::nested("nested")] | ||
| #[case::ranges("ranges")] | ||
| #[should_panic] // This does not yet pass for any case! | ||
| fn optimise_guppy(#[case] name: &str) { |
There was a problem hiding this comment.
To some extent this test is redundant, it's a kind of composition of the other two, but I think it's good to have as a summary (the other two are merely diagnostic really)
Sweet, thanks! 👍 |
Sadly none of the tests reaches the
.opthugr; we do not expect any with a.flathugr to reach that step yet as we are not flattening.