feat!: Interval is independent of resource IDs and scope position

[lmondada]

Previously, Intervals were storing ResourceIds and Positions. This made them only valid for a specific ResourceScope. This data is no longer stored, so that Intervals are now valid independently of the choice of ResourceIds and Positions. See the docstring of Interval and the added test.

BREAKING CHANGE: most methods of resource::Interval now take a ResourceScope argument; Interval::singleton constructor renamed to Interval::new_singleton

[hugrbot]

This PR contains breaking changes to the public Rust API.

cargo-semver-checks summary

    Building tket v0.16.0 (current)
     Built [  40.749s] (current)
   Parsing tket v0.16.0 (current)
    Parsed [   0.095s] (current)
  Building tket v0.16.0 (baseline)
     Built [  40.464s] (baseline)
   Parsing tket v0.16.0 (baseline)
    Parsed [   0.089s] (baseline)
  Checking tket v0.16.0 -> v0.16.0 (assume minor change)
   Checked [   0.079s] 159 checks: 158 pass, 1 fail, 0 warn, 41 skip

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/struct_missing.ron

Failed in:
struct tket::resource::Interval, previously in file /home/runner/work/tket2/tket2/BASELINE_BRANCH/tket/src/resource/interval.rs:13

   Summary semver requires new major version: 1 major and 0 minor checks failed
  Finished [  82.809s] tket
  Building tket-qsystem v0.22.0 (current)
     Built [  42.015s] (current)
   Parsing tket-qsystem v0.22.0 (current)
    Parsed [   0.028s] (current)
  Building tket-qsystem v0.22.0 (baseline)
     Built [  42.351s] (baseline)
   Parsing tket-qsystem v0.22.0 (baseline)
    Parsed [   0.029s] (baseline)
  Checking tket-qsystem v0.22.0 -> v0.22.0 (assume minor change)
   Checked [   0.046s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [  87.067s] tket-qsystem

[codecov]

Codecov Report

❌ Patch coverage is 91.82156% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.07%. Comparing base (ad16531) to head (8b2482c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
tket/src/subcircuit/interval.rs	91.89%	11 Missing and 10 partials ⚠️
tket/src/resource/scope.rs	88.88%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
+ Coverage   78.73%   79.07%   +0.34%     
==========================================
  Files         159      159              
  Lines       20157    20290     +133     
  Branches    19055    19188     +133     
==========================================
+ Hits        15870    16045     +175     
+ Misses       3310     3260      -50     
- Partials      977      985       +8     

Flag	Coverage Δ
python	92.65% <ø> (ø)
qis-compiler	68.40% <ø> (ø)
rust	78.72% <91.82%> (+0.36%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[lmondada]

@mariagg-quantinuum Could you review this please? I cannot requests from you atm 🫠

[mariagg-quantinuum]

Checked this PR, all seems to work and make sense to me 👍 @lmondada
also I think you might be able to set me as a reviewer now so I can tick "review done"

[lmondada]

Cheers, and

I think you might be able to set me as a reviewer now so I can tick "review done"

yes indeed, I can 🎉

[lmondada]

@doug-q this was reviewed by @mariagg-quantinuum, but as she's not an owner of the repo, we would still need your approval.

A second pair of eyes is always good anyways! Thanks in advance 😊

[lmondada]

@doug-q could you please review this when you have a moment?

[doug-q]

Nice