Skip to content

Conversation

@ss2165
Copy link
Member

@ss2165 ss2165 commented Nov 18, 2025

Supercedes #2693

BREAKING CHANGE: exported inkwell upgraded to 0.7, some methods no longer return Either.

BREAKING CHANGE: exported inkwell upgraded to 0.7, some methods no
longer return Either.
@ss2165 ss2165 requested a review from a team as a code owner November 18, 2025 11:16
@ss2165 ss2165 requested a review from croyzor November 18, 2025 11:16
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.53%. Comparing base (a73f871) to head (7f8678a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hugr-llvm/src/emit.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2695   +/-   ##
=======================================
  Coverage   83.53%   83.53%           
=======================================
  Files         264      264           
  Lines       51538    51536    -2     
  Branches    47006    47004    -2     
=======================================
  Hits        43051    43051           
+ Misses       6114     6112    -2     
  Partials     2373     2373           
Flag Coverage Δ
python 91.32% <ø> (ø)
rust 82.78% <95.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

))
}
};
let global_type = global.get_value_type();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@ss2165 ss2165 added this pull request to the merge queue Nov 18, 2025
Merged via the queue into main with commit bb20ee2 Nov 18, 2025
30 checks passed
@ss2165 ss2165 deleted the ss/push-psrwrvwmzoxv branch November 18, 2025 11:39
@hugrbot hugrbot mentioned this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants