Skip to content

Conversation

@ss2165
Copy link
Member

@ss2165 ss2165 commented Nov 17, 2025

BREAKING CHANGE: --hugr-json parameter removed from cli, use package envelopes.

@ss2165 ss2165 requested a review from aborgna-q November 17, 2025 18:03
@ss2165 ss2165 requested a review from a team as a code owner November 17, 2025 18:03
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.53%. Comparing base (f0de151) to head (bee9380).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2690      +/-   ##
==========================================
+ Coverage   83.51%   83.53%   +0.02%     
==========================================
  Files         266      266              
  Lines       51733    51718      -15     
  Branches    47199    47184      -15     
==========================================
- Hits        43206    43204       -2     
+ Misses       6147     6134      -13     
  Partials     2380     2380              
Flag Coverage Δ
python 91.53% <ø> (ø)
rust 82.76% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugrbot
Copy link
Collaborator

hugrbot commented Nov 17, 2025

This PR contains breaking changes to the public Rust API.

cargo-semver-checks summary
    Building hugr v0.24.3 (current)
     Built [  18.486s] (current)
   Parsing hugr v0.24.3 (current)
    Parsed [   0.004s] (current)
  Building hugr v0.24.3 (baseline)
     Built [  17.031s] (baseline)
   Parsing hugr v0.24.3 (baseline)
    Parsed [   0.004s] (baseline)
  Checking hugr v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.011s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [  37.255s] hugr
  Building hugr-cli v0.24.3 (current)
     Built [  15.925s] (current)
   Parsing hugr-cli v0.24.3 (current)
    Parsed [   0.008s] (current)
  Building hugr-cli v0.24.3 (baseline)
     Built [  15.974s] (baseline)
   Parsing hugr-cli v0.24.3 (baseline)
    Parsed [   0.009s] (baseline)
  Checking hugr-cli v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.014s] 159 checks: 157 pass, 2 fail, 0 warn, 41 skip

--- failure enum_variant_missing: pub enum variant removed or renamed ---

Description:
A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_variant_missing.ron

Failed in:
variant CliError::Envelope, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-cli/src/lib.rs:95

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/inherent_method_missing.ron

Failed in:
HugrInputArgs::get_envelope, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-cli/src/hugr_io.rs:63

   Summary semver requires new major version: 2 major and 0 minor checks failed
  Finished [  33.472s] hugr-cli
  Building hugr-core v0.24.3 (current)
     Built [  13.371s] (current)
   Parsing hugr-core v0.24.3 (current)
    Parsed [   0.077s] (current)
  Building hugr-core v0.24.3 (baseline)
     Built [  13.278s] (baseline)
   Parsing hugr-core v0.24.3 (baseline)
    Parsed [   0.076s] (baseline)
  Checking hugr-core v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.161s] 159 checks: 155 pass, 4 fail, 0 warn, 41 skip

--- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] ---

Description:
A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_marked_non_exhaustive.ron

Failed in:
enum ReadError in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-core/src/envelope.rs:139

--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_missing.ron

Failed in:
enum hugr_core::envelope::EnvelopeError, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-core/src/envelope.rs:262

--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/function_missing.ron

Failed in:
function hugr_core::envelope::get_generator, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-core/src/envelope.rs:80

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/struct_missing.ron

Failed in:
struct hugr_core::envelope::WithGenerator, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-core/src/envelope.rs:127

   Summary semver requires new major version: 4 major and 0 minor checks failed
  Finished [  28.307s] hugr-core
  Building hugr-llvm v0.24.3 (current)
     Built [  13.259s] (current)
   Parsing hugr-llvm v0.24.3 (current)
    Parsed [   0.011s] (current)
  Building hugr-llvm v0.24.3 (baseline)
     Built [  13.174s] (baseline)
   Parsing hugr-llvm v0.24.3 (baseline)
    Parsed [   0.010s] (baseline)
  Checking hugr-llvm v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.031s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [  27.641s] hugr-llvm
  Building hugr-model v0.24.3 (current)
     Built [   4.417s] (current)
   Parsing hugr-model v0.24.3 (current)
    Parsed [   0.015s] (current)
  Building hugr-model v0.24.3 (baseline)
     Built [   4.455s] (baseline)
   Parsing hugr-model v0.24.3 (baseline)
    Parsed [   0.014s] (baseline)
  Checking hugr-model v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.025s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [   9.674s] hugr-model
  Building hugr-passes v0.24.3 (current)
     Built [  13.196s] (current)
   Parsing hugr-passes v0.24.3 (current)
    Parsed [   0.023s] (current)
  Building hugr-passes v0.24.3 (baseline)
     Built [  13.235s] (baseline)
   Parsing hugr-passes v0.24.3 (baseline)
    Parsed [   0.023s] (baseline)
  Checking hugr-passes v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.030s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [  28.159s] hugr-passes
  Building hugr-persistent v0.3.4 (current)
     Built [  10.420s] (current)
   Parsing hugr-persistent v0.3.4 (current)
    Parsed [   0.007s] (current)
  Building hugr-persistent v0.3.4 (baseline)
     Built [  10.361s] (baseline)
   Parsing hugr-persistent v0.3.4 (baseline)
    Parsed [   0.007s] (baseline)
  Checking hugr-persistent v0.3.4 -> v0.3.4 (assume minor change)
   Checked [   0.012s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [  21.884s] hugr-persistent

@ss2165 ss2165 force-pushed the ss/push-woxznvopynss branch from 44a2267 to 7dbbf26 Compare November 18, 2025 09:43
@ss2165 ss2165 force-pushed the ss/push-rxuuynoolpxl branch from 4ccb464 to 8160fb7 Compare November 18, 2025 09:43
@aborgna-q aborgna-q added the breaking-change Changes that break semver label Nov 18, 2025
@aborgna-q aborgna-q added this to the hugr-rs 0.25.0 milestone Nov 18, 2025
@ss2165 ss2165 force-pushed the ss/push-woxznvopynss branch from 7dbbf26 to 600df24 Compare November 19, 2025 11:02
@ss2165 ss2165 force-pushed the ss/push-rxuuynoolpxl branch from 8160fb7 to 9d4e83a Compare November 19, 2025 11:02
Base automatically changed from ss/push-woxznvopynss to main November 19, 2025 11:52
BREAKING CHANGE: --hugr-json parameter removed from cli, use package
envelopes.
@ss2165 ss2165 force-pushed the ss/push-rxuuynoolpxl branch from 9d4e83a to bee9380 Compare November 19, 2025 12:39
@ss2165 ss2165 enabled auto-merge November 19, 2025 12:39
@ss2165 ss2165 added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 1edeb25 Nov 19, 2025
30 checks passed
@ss2165 ss2165 deleted the ss/push-rxuuynoolpxl branch November 19, 2025 12:47
@hugrbot hugrbot mentioned this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Changes that break semver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants