Skip to content

Conversation

@ss2165
Copy link
Member

@ss2165 ss2165 commented Nov 12, 2025

Wheel builds are failing when maturin tries to target PyPy because PyPy 3.10 doesn't support stable abi. pyo3 to_str() is not available on non-abi builds so fails. We can use the non-restricted to_cow() instead.

drive-by: use "release-py" profile to build wheels in maturin action

CI test: https://github.com/CQCL/hugr/actions/runs/19307683710

Wheel builds are failing when maturin tries to target PyPy because PyPy
3.10 doesn't support stable abi. pyo3 `to_str()` is not available on
non-abi builds so fails. We can use the non-restricted `to_cow()`
instead.
@ss2165 ss2165 requested a review from aborgna-q November 12, 2025 18:14
@ss2165 ss2165 requested a review from a team as a code owner November 12, 2025 18:14
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.40%. Comparing base (45dc3fc) to head (7473f16).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hugr-model/src/v0/ast/python.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2679   +/-   ##
=======================================
  Coverage   83.40%   83.40%           
=======================================
  Files         264      264           
  Lines       51513    51513           
  Branches    46984    46984           
=======================================
  Hits        42962    42962           
  Misses       6167     6167           
  Partials     2384     2384           
Flag Coverage Δ
python 91.32% <ø> (ø)
rust 82.63% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫠

@ss2165 ss2165 added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 2d40520 Nov 13, 2025
48 of 49 checks passed
@ss2165 ss2165 deleted the ss/push-yrtooqzlptqq branch November 13, 2025 10:06
@hugrbot hugrbot mentioned this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants