Fix connection costs not properly factored in or discounted#232
Merged
BenWinchester merged 4 commits intodevfrom Apr 24, 2024
Merged
Conversation
hamishbeath
approved these changes
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is being opened to address the issue whereby connection costs for households were only factored in for additional households added to the community in subsequent years and not for initial connections.
For example, with the default location of Bahraich, the community starts with 100 households and then expands throughout the simulation and optimisation periods. However, the cost for connecting these households to the mini-grid network is only included for the additional houses which are created throughout the lifetime of the simulation and not for the initial 100 households. Hence, all results in CLOVER under-report on the total cumulative system cost and the LCUE values.
This will be merged into the development branch and will be publicly released as part of CLOVER 5.2 or CLOVER 6. Hence, the version it is being merged into is
5.2.0a7.Linked Issues
This pull request:
Unit tests
This pull request: