Skip to content

Small Fixes #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pvelesko merged 15 commits into from
May 7, 2024
Merged

Small Fixes #844

pvelesko merged 15 commits into from
May 7, 2024

Conversation

@pvelesko
Copy link
Collaborator

@pvelesko pvelesko commented May 5, 2024 •
edited
Loading

  • Add a test which runs valgrind to check that no additional thread safety issues are introduced
  • CMake fixes enabling to recompile the code with modules unloaded
  • CMake fixes to prevent repeated building of hipInfo and ccompat
  • Various other small fixes

@pvelesko pvelesko force-pushed the small-fixes-may4 branch 2 times, most recently from 5a5778d to a852766 Compare May 5, 2024 10:30
@pvelesko pvelesko requested a review from linehill May 6, 2024 02:41
@pvelesko pvelesko force-pushed the small-fixes-may4 branch from a852766 to e2d4e87 Compare May 6, 2024 23:38
@pvelesko pvelesko force-pushed the small-fixes-may4 branch from f628d73 to 9057929 Compare May 7, 2024 06:33
linehill
linehill approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@linehill linehill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@pvelesko pvelesko merged commit 339defd into main May 7, 2024
@pvelesko pvelesko deleted the small-fixes-may4 branch May 7, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linehill linehill linehill approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pvelesko @linehill