Fixes scripts/configure_llvm.sh #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clone chipStar's fork of LLVM to match root README.md instructions. * Fix mix-up of SPIRV_BRANCH and TRANSLATOR_BRANCH. * `git br ...` -> `git branch ...`. The br command alias does not seems to be available in some git versions. * Fix static library build option lacked -DLLVM_ENABLE_ASSERTIONS=On (assuming it's desired since the dynamic library option has it). * Fix the script failed on SPIR-V translator branch checkout when runnig the script on already cloned LLVM. Fixes #834.
Collaborator
|
Thanks @linehill I'm not sure what happened here bc we definitely used our fork previously. |
Collaborator
Author
I made branches for LLVM 18 (https://github.com/CHIP-SPV/llvm-project/tree/chipStar-llvm-18, https://github.com/CHIP-SPV/llvm-project/tree/spirv-ext-fixes-18). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone chipStar's fork of LLVM to match root README.md instructions.
Fix mix-up of SPIRV_BRANCH and TRANSLATOR_BRANCH.
git br ...->git branch .... The br command alias does not seems to be available in some git versions.Fix static library build option lacked
-DLLVM_ENABLE_ASSERTIONS=On(assuming it's desired since the dynamic library option has it).Fix the script failed on SPIR-V translator branch checkout when runnig the script on already cloned LLVM.
Fixes #834.