Fix HIP float intrinsics were mapped double built-ins #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Linter error + Question: So the opencl intrinsics are declared here, shouldn't the mappping also change? Or was the mapping done in the previous PR without declaration which would have resulted in compilation issues? If it's the latter we need to adjust testing |
The use-compiler-builtins patch removed OpenCL single-precision built-in declarations, thought to be redundant, but this silently broke HIP intrinsics which relied on them. HIP intrinsics that called single-precision OpenCL built-ins previously, called double-precision variants after the patch (perf. drop, especially on devices without double support). Fix by bringing the OpenCL single-precision built-in declarations where they are needed.
Collaborator
Author
|
Lint fix.
This patch brings the mapping to the state it was before #763 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use-compiler-builtins patch unintentionally redirected HIP single precision intrinsic calls to double precision compiler/OpenCL built-ins.