Fix tests were unintentinally skipped #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjaaskel
approved these changes
Jan 26, 2024
Fix tests under `tests/runtime/` were unintentinally skipped in debug builds due to word "SKIP" appearing in the chipStar's debug prints. More specifically, the tests were skipped due to `CHIP debug ... : CHIP_SKIP_UNINIT=...` messages. Fixed the issue by changing the skipping logic to be exit code based.
pvelesko
force-pushed
the
fix-skipped-tests
branch
from
7d866c8 to
f223fcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests under
tests/runtime/were unintentinally skipped in debug builds due to word "SKIP" appearing in the chipStar's debug prints. More specifically, the tests were skipped due toCHIP debug ... : CHIP_SKIP_UNINIT=...messages.Fixed the issue by changing the skipping logic to be exit code based.