-
Notifications
You must be signed in to change notification settings - Fork 44
Escape code in tables #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
edcac27
Add fixture for tables with escaped characters
chriskrycho 37e8dcb
Escape special characters in inline code in tables
chriskrycho e7f0784
Improve test expectations for escaping pipes in inline code
chriskrycho 13785fe
feat!: Make `State` struct non-exhaustive
chriskrycho c9ecdd2
Correct comment/note on when pipe characters are/not escaped
chriskrycho 022fa11
Use `Cow<'a, str>` to minimize allocations for pipe escaping
chriskrycho a85fe39
Add fixtures for pipes-in-code which should *not* be escaped
chriskrycho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| |First|Second|Third|Fourth| | ||
chriskrycho marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| |-----|------|-----|------| | ||
| |`\|`|`\\`|`a\[b\]`|`>>`| | ||
|
|
||
| Normal inline code with pipes `|` should not be re-escaped, because it does not | ||
| cause a problem! | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| | First | Second | Third | Fourth | | ||
| | ----- | ------ | -------- | ------ | | ||
| | `\|` | `\\` | `a\[b\]` | `>>` | | ||
|
|
||
| Normal inline code with pipes `|` should not be re-escaped, because it does not | ||
| cause a problem! |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.