fix[utils][smartling]: ENG-11017 fix for apply translations#4211
fix[utils][smartling]: ENG-11017 fix for apply translations#4211anaghav2023 merged 2 commits intoBuilderIO:mainfrom
Conversation
|
|
View your CI Pipeline Execution ↗ for commit c886032
☁️ Nx Cloud last updated this comment at |
| data, | ||
| basePath, | ||
| path, | ||
| translationPath, |
There was a problem hiding this comment.
is this method used only by smartling plugin? what about phrase?
There was a problem hiding this comment.
So this method is called by the applyTranslation method, which is being used in the mesource file, which is the phrase plugin. But I have tested this function for backward compatibility. It is only handling the additional cases and the existing test cases are also passed. So should be okay. For safety, I could introduce a new v2 function and call it from smartling
Description
Handles apply translation for nested symbols data.
Testing:
loom.com/share/9f493b9bf39b4e74aea1493ad8b089a6?focus_title=1&muted=1&from_recorder=1
Note
Refactors translation application to handle nested LocalizedValue inside symbol inputs, including arrays, and adds tests; bumps utils to 1.1.27.
resolveTranslationto support nestedLocalizedValuewithin symbol inputs, including arrays/objects.translationPathanddataPathto look up vs. set values.Defaultand locale-specific branches; updatetransformed.symbol.data.*meta keys.uspList).@builder.io/utilsversion to1.1.27.Written by Cursor Bugbot for commit c886032. This will update automatically on new commits. Configure here.