Skip to content

Conversation

@slang25
Copy link
Collaborator

@slang25 slang25 commented May 7, 2024

Fixes #271

@slang25
Copy link
Collaborator Author

slang25 commented May 7, 2024

It might be worth making the escape behaviour a bit more complete, opinions welcome:
https://github.com/dotnet/msbuild/blob/ad4df597b038182ff632602c1e2f59f3ed131d76/src/Shared/EscapingUtilities.cs#L284-L310

@phmonte
Copy link
Collaborator

phmonte commented May 8, 2024

@slang25 do you see a way to create a unit test for this scenario?

I believe this problem will not only happen with the ";"

@phmonte phmonte merged commit e1c24ec into Buildalyzer:main May 13, 2024
@slang25
Copy link
Collaborator Author

slang25 commented May 13, 2024

I'll follow up with some tests and a fuller PR soon 🙂

@softlion
Copy link

@slang25 do you see a way to create a unit test for this scenario?

I believe this problem will not only happen with the ";"

This happens because of how linux sh/bash interpreter works.

You only need to escape ";" "," and space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buildalyzer hangs if build does not start

4 participants