Restore sorting empty target framework last #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8e85a15 dropped the NuGet.Frameworks dependency and as a result sorting of the target frameworks behaviour changed. Previously, the `NuGetFrameworkSorter` would sort the empty target framework last. Since 8e85a15 the empty target framework is sorted first. This commit restores the old behaviour of sorting the empty target framework last. Note: Stryker.NET was inadvertently depending on this behaviour, so v6.0.1 broke Stryker.NET. I have [fixed the issue in Styker.NET](stryker-mutator/stryker-net#2811) but I think restoring the previous sorting behaviour is a good idea anyway.
Collaborator
|
Yikes, sorry! And good catch - nice work on bringing back a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8e85a15 dropped the NuGet.Frameworks dependency and as a result sorting of the target frameworks behaviour changed.
Previously, the
NuGetFrameworkSorterwould sort the empty target framework last. Since 8e85a15 the empty target framework is sorted first.This commit restores the old behaviour of sorting the empty target framework last.
Note: Stryker.NET was inadvertently depending on this behaviour, so v6.0.1 broke Stryker.NET. I have fixed the issue in Styker.NET but I think restoring the previous sorting behaviour is a good idea anyway.