Skip to content

Conversation

@sxlijin
Copy link
Collaborator

@sxlijin sxlijin commented Oct 1, 2025

The internal name is set_log_max_chunk_length, but that's not a good user-visible name

@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
promptfiddle Skipped Skipped Oct 1, 2025 9:18pm

@sxlijin sxlijin temporarily deployed to boundary-tools-dev October 1, 2025 21:18 — with GitHub Actions Inactive
@sxlijin sxlijin temporarily deployed to boundary-tools-dev October 1, 2025 21:18 — with GitHub Actions Inactive
@sxlijin sxlijin temporarily deployed to boundary-tools-dev October 1, 2025 21:18 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

@entelligence-ai-pr-reviews
Copy link

🔒 Entelligence AI Vulnerability Scanner

No security vulnerabilities found!

Your code passed our comprehensive security analysis.

📊 Files Analyzed: 2 files


@entelligence-ai-pr-reviews
Copy link

Review Summary

🏷️ Draft Comments (2)

Skipped posting 2 draft comments that were valid but scored below your review threshold (>=10/15). Feel free to update them here.

engine/language_client_python/python_src/baml_py/logging.py (2)

4-4: set_log_max_message_length is assigned as an alias to set_log_max_chunk_length, but if set_log_max_chunk_length is later replaced or deleted, the alias will not update, potentially breaking the contract for users expecting the alias to always reflect the current function.

📊 Impact Scores:

  • Production Impact: 2/5
  • Fix Specificity: 5/5
  • Urgency Impact: 2/5
  • Total Score: 9/15

🤖 AI Agent Prompt (Copy & Paste Ready):

In engine/language_client_python/python_src/baml_py/logging.py, lines 4-4, the alias `set_log_max_message_length = set_log_max_chunk_length` is a direct assignment. This can break if `set_log_max_chunk_length` is replaced or deleted later, causing the alias to point to an outdated or missing function. Replace the alias with a wrapper function that always calls the current `set_log_max_chunk_length` implementation.

6-12: __all__ is not sorted alphabetically, violating Python best practices and reducing maintainability for module exports.

📊 Impact Scores:

  • Production Impact: 1/5
  • Fix Specificity: 5/5
  • Urgency Impact: 1/5
  • Total Score: 7/15

🤖 AI Agent Prompt (Copy & Paste Ready):

In engine/language_client_python/python_src/baml_py/logging.py, lines 6-12, the `__all__` list is not sorted alphabetically, which violates Python module export conventions and reduces maintainability. Please reorder the `__all__` list so that all entries are in alphabetical order.

🔍 Comments beyond diff scope (1)
engine/generators/languages/python/src/_templates/config.py (1)

69-73: set_log_max_chunk_length is defined without parameters but is called with *args, **kwargs in set_log_max_message_length, causing a TypeError at runtime if arguments are passed.
Category: correctness


@entelligence-ai-pr-reviews
Copy link

LGTM 👍

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sxlijin sxlijin added this pull request to the merge queue Oct 1, 2025
Merged via the queue into canary with commit 2c689dc Oct 1, 2025
25 checks passed
@sxlijin sxlijin deleted the cursor/fix-typo-in-log-message-length-function-88fd branch October 1, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants