fix(language-server): handle non-baml-src baml files #2506

sxlijin · 2025-09-23T20:04:22Z

Roll forward of #2486, with deadlocks fixed.

Deadlocks were present because session.reload() needs to grab locks on every project, but its API does not make this obvious, and in #2486 there were implicit scope changes that resulted in MutexGuard destructors not running before session.reload() got called.

entelligence-ai-pr-reviews · 2025-09-23T20:05:18Z

🔒 Entelligence AI Vulnerability Scanner

✅ No security vulnerabilities found!

Your code passed our comprehensive security analysis.

entelligence-ai-pr-reviews · 2025-09-23T20:05:19Z

LGTM 👍

github-actions · 2025-09-23T20:06:11Z

🌿 Preview your docs: https://boundary-preview-9db42254-7f3e-4609-a0c6-f22f612ddbc5.docs.buildwithfern.com

vercel · 2025-09-23T20:06:23Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
promptfiddle	Skipped			Sep 25, 2025 9:21pm

codecov · 2025-09-23T20:11:23Z

Codecov Report

❌ Patch coverage is 9.30233% with 117 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...server/api/notifications/did_save_text_document.rs	0.00%	24 Missing ⚠️
...gine/language_server/src/server/api/diagnostics.rs	0.00%	21 Missing ⚠️
...e_server/src/server/api/notifications/did_close.rs	0.00%	15 Missing ⚠️
engine/language_server/src/session.rs	52.17%	11 Missing ⚠️
...ge_server/src/server/api/notifications/did_open.rs	0.00%	9 Missing ⚠️
engine/language_server/src/server/api.rs	0.00%	7 Missing ⚠️
..._server/src/server/api/notifications/did_change.rs	0.00%	6 Missing ⚠️
...rver/api/notifications/did_change_watched_files.rs	0.00%	5 Missing ⚠️
...guage_server/src/server/api/requests/completion.rs	0.00%	4 Missing ⚠️
...guage_server/src/server/api/requests/diagnostic.rs	0.00%	4 Missing ⚠️
... and 5 more

📢 Thoughts on this report? Let us know!

chatgpt-codex-connector

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

chatgpt-codex-connector · 2025-09-23T20:15:11Z

engine/language_server/src/server/api/notifications/did_change_watched_files.rs

+        if params.changes.iter().any(|change| {
+            let Ok(path) = change.uri.to_file_path() else {
+                return true;
+            };
+            session.get_or_create_project(&path).is_err()
+        }) {
            return Ok(());


[P1] Avoid dropping watched-file batches with mixed paths

The new guard returns early whenever any change in the batch cannot be resolved to a baml_src project. This skips the reload and diagnostic publishing for the entire batch, even when the same batch contains valid baml_src files. The previous code only bailed out when no baml_src paths were present. A watcher that reports both BAML and non-BAML file events (e.g. a generator output alongside a source change) will now leave diagnostics stale for the actual BAML file. Filter out non-BAML entries instead of aborting the whole handler.

Useful? React with 👍 / 👎.

i think this is valid no?

github-actions · 2025-09-23T21:01:39Z

https://sage-backend-e6mvwf1z9-baml.vercel.app

github-actions · 2025-09-24T23:01:05Z

🌿 Preview your docs: https://boundary-preview-4d9769c5-1754-48a9-af0d-cff1b49dff4f.docs.buildwithfern.com

github-actions · 2025-09-24T23:01:40Z

https://sage-backend-511b2lrop-baml.vercel.app

github-actions · 2025-09-25T19:48:50Z

🌿 Preview your docs: https://boundary-preview-77ac7d03-771e-4af3-b325-0269e080469e.docs.buildwithfern.com

github-actions · 2025-09-25T19:57:24Z

🌿 Preview your docs: https://boundary-preview-08faac3a-c892-44f0-befa-128e6d4418b0.docs.buildwithfern.com

github-actions · 2025-09-25T20:04:37Z

https://sage-backend-dkjn0qiiw-baml.vercel.app

github-actions · 2025-09-25T21:23:40Z

🌿 Preview your docs: https://boundary-preview-5b7dc2ea-0c6a-472e-ab6e-325a73e7c9b4.docs.buildwithfern.com

github-actions · 2025-09-25T21:24:14Z

https://sage-backend-izlzqbi38-baml.vercel.app

sxlijin temporarily deployed to boundary-tools-dev September 23, 2025 20:04 — with GitHub Actions Inactive

chatgpt-codex-connector bot reviewed Sep 23, 2025

View reviewed changes

vercel bot temporarily deployed to Preview September 23, 2025 21:00 Inactive

sxlijin temporarily deployed to boundary-tools-dev September 24, 2025 22:59 — with GitHub Actions Inactive

vercel bot temporarily deployed to Preview September 24, 2025 22:59 Inactive

vercel bot temporarily deployed to Preview September 24, 2025 23:23 Inactive

sxlijin force-pushed the sam/vscode-playground branch from 9762467 to 9fcf85c Compare September 25, 2025 00:19

vercel bot temporarily deployed to Preview September 25, 2025 01:22 Inactive

sxlijin added 6 commits September 25, 2025 12:47

restore language server changes

ed5383f

fix deadlock issues

833792e

code workspace

17d8f17

mise generator

0df8e7d

revert settings change

250f71f

inconsistent logic

dfce4bd

sxlijin force-pushed the sam/vscode-playground branch from 9fcf85c to dfce4bd Compare September 25, 2025 19:47

sxlijin had a problem deploying to boundary-tools-dev September 25, 2025 19:47 — with GitHub Actions Error

sxlijin temporarily deployed to boundary-tools-dev September 25, 2025 19:47 — with GitHub Actions Inactive

oops

0c5a173

vercel bot temporarily deployed to Preview September 25, 2025 19:55 Inactive

sxlijin temporarily deployed to boundary-tools-dev September 25, 2025 19:55 — with GitHub Actions Inactive

integ tests

5ff08ed

vercel bot temporarily deployed to Preview September 25, 2025 21:21 Inactive

sxlijin temporarily deployed to boundary-tools-dev September 25, 2025 21:21 — with GitHub Actions Inactive

sxlijin added this pull request to the merge queue Sep 25, 2025

Merged via the queue into canary with commit 613df6b Sep 25, 2025
25 checks passed

sxlijin deleted the sam/vscode-playground branch September 25, 2025 22:07

fix(language-server): handle non-baml-src baml files #2506

fix(language-server): handle non-baml-src baml files #2506

Uh oh!

Conversation

sxlijin commented Sep 23, 2025

Uh oh!

entelligence-ai-pr-reviews bot commented Sep 23, 2025

Uh oh!

entelligence-ai-pr-reviews bot commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

vercel bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 23, 2025

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

aaronvg Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Sep 23, 2025 •

edited

Loading