Add tests for PSBT security analysis tools#26
Closed
ThomsenDrake wants to merge 1 commit intoBortlesboat:mainfrom
Closed
Add tests for PSBT security analysis tools#26ThomsenDrake wants to merge 1 commit intoBortlesboat:mainfrom
ThomsenDrake wants to merge 1 commit intoBortlesboat:mainfrom
Conversation
Add TestPSBTSecurity test class with 17 tests covering: - Error handling: invalid hex, wrong magic, empty input, raw Bitcoin tx - Tool wrappers: analyze_psbt_security and explain_inscription_listing_security JSON/str returns - Helper functions: _psbt_read_varint roundtrip, _psbt_is_2of2_multisig (valid/invalid/wrong length) - BIP 174 PSBT parsing: magic bytes, empty map, sighash type constants Issue Bortlesboat#8: Add tests for PSBT security analysis tool (safety-critical, handles user funds)
Owner
|
Closing this as superseded by #31, which consolidates the open backlog work into one maintainer sweep. Thank you for the contribution and the concrete issue coverage here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add TestPSBTSecurity test class with 17 tests covering:
Issue Reference
Fixes #8: Add tests for PSBT security analysis tool (safety-critical, handles user funds)
Testing
All 17 tests pass locally. This PR also verifies the 141 existing tests continue to pass.
PR Type