Sorting notes alphabetically now sort starting numbers in titles right

[dredav]

Description

Sorting titles with numbers tries to match float values of left and right titles at comparison. When both numbers are floats and not equal we can do a direct compare. In all other cases the full title will compare.

Screenshot before

Screenshot after

Issue fixed

#2894

Type of changes

• 🔵 Bug fix (Change that fixed an issue)
• ⚪ Breaking change (Change that can cause existing functionality to change)
• ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
• ⚪ Feature (Change that adds new functionality)
• ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

• 🔵 My code follows the project code style
• ⚪ I have written test for my code and it has been tested
• 🔵 All existing tests have been passed
• 🔵 I have attached a screenshot/video to visualize my change if possible

[ZeroX-DG]

LGTM 🎉

[Rokt33r]

Rather than using if statement, return floatA - floatB should be enough.

[Rokt33r]

@dredav I've submitted a change request. I'll merge this as soon as you resolve it.

[dredav]

@dredav I've submitted a change request. I'll merge this as soon as you resolve it.

Thanks for your review @Rokt33r. I've removed the if / else if to return-1 or 1, but I must add a Math.Abs call to check if the floats are equal or not. For the equal case we need to compare the full note title in case for title example 1.0 Note 2 and 1.0 Note 1.

[dredav]

@Rokt33r What do you think?

@dredav I've submitted a change request. I'll merge this as soon as you resolve it.

Thanks for your review @Rokt33r. I've removed the if / else if to return-1 or 1, but I must add a Math.Abs call to check if the floats are equal or not. For the equal case we need to compare the full note title in case for title example 1.0 Note 2 and 1.0 Note 1.

[Rokt33r]

Sorry for my late review. How do you think? @dredav