Skip to content

Sorting notes alphabetically now sort starting numbers in titles right #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rokt33r merged 4 commits into from
May 9, 2019
Merged

Sorting notes alphabetically now sort starting numbers in titles right #2910

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5c47f1
fix issue #2894: sort alphabetical will now parse float values starti…
dredav Mar 2, 2019
af9a874
rename const
dredav Mar 2, 2019
7445059
Check if the float is quals (abs value is greather 0.01) and return t…
dredav Mar 25, 2019
2c2442a
change return handling of sortByAlphabetical
dredav May 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions browser/main/NoteList/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,29 @@ const { remote } = require('electron')
const { dialog } = remote
const WP_POST_PATH = '/wp/v2/posts'

const regexMatchStartingTitleNumber = new RegExp('^([0-9]*\.?[0-9]+).*$')

function sortByCreatedAt (a, b) {
return new Date(b.createdAt) - new Date(a.createdAt)
}

function sortByAlphabetical (a, b) {
const matchA = regexMatchStartingTitleNumber.exec(a.title)
const matchB = regexMatchStartingTitleNumber.exec(b.title)

if (matchA && matchA.length === 2 && matchB && matchB.length === 2) {
// Both note titles are starting with a float. We will compare it now.
const floatA = parseFloat(matchA[1])
const floatB = parseFloat(matchB[1])

const diff = floatA - floatB
if (diff !== 0) {
return diff
}

// The float values are equal. We will compare the full title.
}

return a.title.localeCompare(b.title)
}

Expand Down