Skip to content

Fix #982: Tag list cannot be scroll #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kazup01 merged 1 commit into from
Oct 18, 2017
Merged

Fix #982: Tag list cannot be scroll #988

kazup01 merged 1 commit into from
Oct 18, 2017

Conversation

@aoki
Copy link
Contributor

@aoki aoki commented Oct 17, 2017 •
edited
Loading

This PR resolve #982.
I give height to the .root of SideNav.

Before

tag-sgroll_before

After

tag-sgroll

@BoostnoteBot
Copy link
Collaborator

BoostnoteBot commented Oct 17, 2017

Please make sure to be pasted screenshots of all your changes.

@aoki aoki changed the title Fix #928: Tag list cannot be scroll Fix #982: Tag list cannot be scroll Oct 17, 2017
@kazup01 kazup01 self-requested a review October 18, 2017 07:34
kazup01
kazup01 approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 4744b91 into BoostIO:master Oct 18, 2017
@kazup01
Copy link
Member

kazup01 commented Oct 18, 2017

Thanks for your great support!<333 @ringoHub

@aoki aoki deleted the fix/982-can_not_scroll_tag_list branch October 18, 2017 08:43
@kohei-takata kohei-takata mentioned this pull request Oct 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazup01 kazup01 kazup01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TagList cannot be scroll.

3 participants

@aoki @BoostnoteBot @kazup01