-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Improve searching #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve searching #954
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b4f5913
Fix to work inputting by IME on search
asmsuechan 6e480ba
Add comments
asmsuechan 4418617
Delete a unnecessary break
asmsuechan 2511512
Improve context search
asmsuechan 70468b6
Change contextNotes a state to a variable because of lifesycle loop
asmsuechan da6b8c3
Improve some
asmsuechan df3195f
Refactor getContextNotes()
asmsuechan 93e188d
Change to be able to search on starred
asmsuechan 49243a8
Add to handle space key on search
asmsuechan 15dc424
Change keycode handling scope due to global keyboard support
asmsuechan caa5dea
Change searching by tag
asmsuechan 78b12ae
Add test
asmsuechan 7ab4821
Improve tag search by changing the logic
asmsuechan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work on various keyCodes... Need to change.
German: üöä
French: ù
Spanish: ñ
Russian: (work fine)
Chinese: (work fine by using pinyin keyboard)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to extend the keyCode scope to
e.keyCode<=90 || 186<=e.keyCode<=222according to http://www.javascripter.net/faq/keycodes.htm.