Skip to content

Conversation

@sferra
Copy link
Contributor

@sferra sferra commented Sep 25, 2017

This fixes the issue of the notification bar convering the "collapse" button of the navigation bar. See #904

@kazup01
Copy link
Member

kazup01 commented Sep 25, 2017

Thanks for your support @sferra ! Could you attach the image?

@sferra
Copy link
Contributor Author

sferra commented Sep 25, 2017

I just noticed that the notification is not centered. I'll try to fix that too.

screenshot from 2017-09-25 17-27-56
screenshot from 2017-09-25 17-27-49

@sferra
Copy link
Contributor Author

sferra commented Sep 25, 2017

The notification is now centered in the notification bar.
screenshot from 2017-09-25 18-47-17

@kazup01
Copy link
Member

kazup01 commented Sep 25, 2017

Thanks so much @sferra ! Your PRs are very helpful.

1, Could you fix layout at expand mode?
screen shot 0029-09-26 at 2 18 45 am

2, How do you think about bringing the Notification area to the right? I think this layout looks better.
screen shot 0029-09-26 at 2 24 06 am

Thanks!

@sferra
Copy link
Contributor Author

sferra commented Sep 25, 2017

@kazup01 thanks for testing. i would prefer to address the "notification" position with a separate pull request if that's okay with you. the notification position might be an improvement but it's not related to the actual bug of not being able to toggle the navigation bar.

@kazup01 kazup01 self-requested a review September 26, 2017 04:01
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit e647338 into BoostIO:master Sep 26, 2017
@kazup01
Copy link
Member

kazup01 commented Sep 26, 2017

merged🎉 Thank you for your quick cooperation! @sferra

@kazup01
Copy link
Member

kazup01 commented Sep 26, 2017

Could you also send us a PR that fix "notification" to the right side?

@sferra sferra deleted the fix-collapse-sidebar-button-not-visible branch September 26, 2017 10:01
@kohei-takata kohei-takata mentioned this pull request Oct 28, 2017
@kazup01
Copy link
Member

kazup01 commented Oct 28, 2017

This feature has just released at v0.8.16! Thanks!
#1027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants