Add a module to find the title #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sota1235
reviewed
May 6, 2017
browser/lib/findNoteTitle.js
Outdated
| @@ -0,0 +1,32 @@ | |||
| export function find (value) { | |||
Contributor
There was a problem hiding this comment.
[Question] Why didn't you name this method like findNoteTitle?
I think find is a little ambiguous.
Contributor
Author
There was a problem hiding this comment.
Because I don't like
repetition like findNoteTitle.findNoteTitle(). What do you think noteUtils.findNoteTitle()?
The reason why I didn't choose that name is because I add only 1 method this time. I thought don't need to change the name to noteUtils unless need to add a lotta methods.
Contributor
There was a problem hiding this comment.
Is the way like below is better for you?
export function findNoteTitle() {
//
}
export default {
findNoteTitle,
}import { findNoteTitle } from 'browser/lib/findNoteTitle'
Contributor
Author
There was a problem hiding this comment.
Oh, yes! It's the better way 😄
sota1235
suggested changes
May 6, 2017
Contributor
sota1235
left a comment
sota1235
left a comment
There was a problem hiding this comment.
Please confirm the comment.
asmsuechan
changed the title
Contributor
Author
|
@sota1235 I fixed the name 🙏 |
…d inside the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a module to find a title of a note.