Skip to content

fix the bug when using markdown syntax h1 #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asmsuechan merged 6 commits into from
May 20, 2017
Merged

fix the bug when using markdown syntax h1 #510

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b8488a
fix the bug when using markdown syntax h1
sosukesuzuki Apr 26, 2017
11f7fcb
fix the bug that is markdown titile starts with second letter
sosukesuzuki Apr 26, 2017
2ed0922
avoid undefined
sosukesuzuki May 17, 2017
7265f76
for loop change to forEach
sosukesuzuki May 17, 2017
a528c99
change from 'undefined' to undefined
sosukesuzuki May 20, 2017
575f1b4
change from forEach to some
sosukesuzuki May 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions browser/main/Detail/MarkdownNoteDetail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,20 @@ class MarkdownNoteDetail extends React.Component {
let title = null
let isMarkdownInCode = false

for (let i = 0; i < splitted.length; i++) {
let trimmedLine = splitted[i].trim()
splitted.forEach((line, index) => {
let trimmedLine = line.trim()
let trimmedNextLine = typeof splitted[index + 1] === 'undefined' ? '' : splitted[index + 1].trim()
Copy link
Contributor

@asmsuechan asmsuechan May 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use just splitted[index + 1] === undefined.

if (trimmedLine.match('```')) {
isMarkdownInCode = !isMarkdownInCode
} else if (isMarkdownInCode === false && trimmedLine.match(/^# +/)) {
title = trimmedLine.substring(1, trimmedLine.length).trim()
break
} else if (isMarkdownInCode === false && (trimmedLine.match(/^# +/) || trimmedNextLine.match('='))) {
if (trimmedNextLine.match('=')) {
title = trimmedLine.substring(0, trimmedLine.length).trim()
} else {
title = trimmedLine.substring(1, trimmedLine.length).trim()
}
return
}
}
})

if (title == null) {
for (let i = 0; i < splitted.length; i++) {
Expand Down