Skip to content

Fix note title #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kazup01 merged 11 commits into from
Nov 9, 2017
Merged

Fix note title #398

kazup01 merged 11 commits into from
Nov 9, 2017

Conversation

@asmsuechan
Copy link
Contributor

@asmsuechan asmsuechan commented Apr 8, 2017 •
edited
Loading

I change to show underscores(_) in title

1825ed2fb5d8232730022ffca935d58b

@asmsuechan asmsuechan mentioned this pull request Apr 8, 2017
Closed
@sota1235
Copy link
Contributor

sota1235 commented Apr 22, 2017

I think it is too hard to read. So I added unit test.
https://github.com/asmsuechan/Boostnote/pull/4

Please confirm it.

@sota1235 sota1235 self-requested a review April 22, 2017 03:46
sota1235
sota1235 suggested changes Apr 22, 2017
View reviewed changes
Copy link
Contributor

@sota1235 sota1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm the comment.

@asmsuechan
Copy link
Contributor Author

asmsuechan commented Apr 23, 2017

I think so. I assume that PR is better.

@kazup01 kazup01 added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label May 17, 2017
@asmsuechan asmsuechan mentioned this pull request Jun 9, 2017
Closed
@asmsuechan asmsuechan removed the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Jun 18, 2017
@sota1235
Copy link
Contributor

sota1235 commented Nov 5, 2017

@asmsuechan plz resolve conflicts

@kazup01 kazup01 added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Nov 7, 2017
@asmsuechan
Copy link
Contributor Author

asmsuechan commented Nov 7, 2017

Done.

@kazup01 kazup01 added awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Nov 8, 2017
sota1235
sota1235 approved these changes Nov 9, 2017
View reviewed changes
Copy link
Contributor

@sota1235 sota1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing

@sota1235 sota1235 added Next Release and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 9, 2017
@kazup01 kazup01 merged commit 11c46ed into BoostIO:master Nov 9, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 9, 2017

Merged. Thank you for your contribution @asmsuechan !

@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
Merged
@kohei-takata kohei-takata mentioned this pull request Dec 3, 2017
Merged
@kohei-takata kohei-takata mentioned this pull request Dec 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sota1235 sota1235 sota1235 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@asmsuechan asmsuechan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asmsuechan @sota1235 @kazup01 @BoostnoteBot