Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Change app reload shortcut to ctrl + shift + r #3645

Closed
KonradLinkowski wants to merge 1 commit into from
Closed

Change app reload shortcut to ctrl + shift + r #3645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/main-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ const view = {
submenu: [
{
label: 'Reload',
accelerator: 'CommandOrControl+R',
accelerator: 'CommandOrControl+Shift+R',

@Flexo013 Flexo013 Sep 29, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reason to change the shortcut for all users. This change should only be made for users of vim keybinds.

@KonradLinkowski KonradLinkowski Sep 30, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it seemed like a development feature. I don't see a situation when somebody would want to reload the app.

@Flexo013 Flexo013 Oct 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reloading the app is used similarly as the refresh button in your browser. It updates any files that might have changed due to external (cloud sync) changes. Any changes to configs that might have failed to propagate (or were synced) will also only be applied after a reload of the app.

Since the conflict only exists for users of vim keybinds, the issue only needs to solved there.

click() {
BrowserWindow.getFocusedWindow().reload()
}
Expand Down