Skip to content

fix: #288 Fixed Snippet tabs overwriting other tabs when closed #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asmsuechan merged 3 commits into from
Mar 23, 2017
Merged

fix: #288 Fixed Snippet tabs overwriting other tabs when closed #352

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b4921b
fix: #288 Fixed Snippet tabs overwriting other tabs when closed
Mar 23, 2017
966ba06
change let to const
Mar 23, 2017
6540d26
better formatting
Mar 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions browser/components/CodeEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ export default class CodeEditor extends React.Component {
this.editor.setValue(this.props.value)
this.editor.clearHistory()
this.editor.on('change', this.changeHandler)
this.editor.refresh()
}

setValue (value) {
Expand Down
22 changes: 13 additions & 9 deletions browser/main/Detail/SnippetNoteDetail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,17 +250,21 @@ class SnippetNoteDetail extends React.Component {
}

deleteSnippetByIndex (index) {
let snippets = this.state.note.snippets.slice()
snippets.splice(index, 1)
this.state.note.snippets = snippets
let snippetIndex = this.state.snippetIndex >= snippets.length
? snippets.length - 1
: this.state.snippetIndex
this.setState({
note: this.state.note,
snippetIndex
this.setState(() => {
let snippets = this.state.note.snippets.slice()
Copy link
Contributor

@asmsuechan asmsuechan Mar 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change let to const?

Copy link
Contributor Author

@redcom redcom Mar 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

snippets.splice(index, 1)
let note = Object.assign({}, this.state.note, {snippets})
let snippetIndex = this.state.snippetIndex >= snippets.length
? snippets.length - 1
: this.state.snippetIndex

return {
note,
snippetIndex
}
}, () => {
this.save()
this.refs['code-' + this.state.snippetIndex].reload()
})
}

Expand Down