Skip to content

Remove a menu which is shown on clicked the trash button #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazup01 merged 2 commits into from
Apr 5, 2017
Merged

Remove a menu which is shown on clicked the trash button #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1de67a0
Remove a menu which is shown on clicked the trash button
asmsuechan Mar 27, 2017
40b7ce6
Add it to snippet note
asmsuechan Mar 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions browser/main/Detail/MarkdownNoteDetail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,16 +181,7 @@ class MarkdownNoteDetail extends React.Component {

}

handleContextButtonClick (e) {
let menu = new Menu()
menu.append(new MenuItem({
label: 'Delete',
click: (e) => this.handleDeleteMenuClick(e)
}))
menu.popup(remote.getCurrentWindow())
}

handleDeleteMenuClick (e) {
handleDeleteButtonClick (e) {
let index = dialog.showMessageBox(remote.getCurrentWindow(), {
type: 'warning',
message: 'Delete a note',
Expand Down Expand Up @@ -291,7 +282,7 @@ class MarkdownNoteDetail extends React.Component {
)
})()}
<button styleName='control-trashButton'
onClick={(e) => this.handleContextButtonClick(e)}
onClick={(e) => this.handleDeleteButtonClick(e)}
>
<svg height='17px' id='Capa_1' style={{enableBackground: 'new 0 0 753.23 753.23'}} width='17px' version='1.1' viewBox='0 0 753.23 753.23' x='0px' y='0px' xmlSpace='preserve'>
<g>
Expand Down
11 changes: 2 additions & 9 deletions browser/main/Detail/SnippetNoteDetail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,14 +189,7 @@ class SnippetNoteDetail extends React.Component {

}

handleContextButtonClick (e) {
context.popup([{
label: 'Delete',
click: (e) => this.handleDeleteMenuClick(e)
}])
}

handleDeleteMenuClick (e) {
handleDeleteButtonClick (e) {
let index = dialog.showMessageBox(remote.getCurrentWindow(), {
type: 'warning',
message: 'Delete a note',
Expand Down Expand Up @@ -546,7 +539,7 @@ class SnippetNoteDetail extends React.Component {
</div>
<div styleName='info-right'>
<button styleName='control-trashButton'
onClick={(e) => this.handleContextButtonClick(e)}
onClick={(e) => this.handleDeleteButtonClick(e)}
>
<svg height='17px' id='Capa_1' style={{enableBackground: 'new 0 0 753.23 753.23'}} width='17px' version='1.1' viewBox='0 0 753.23 753.23' x='0px' y='0px' xmlSpace='preserve'>
<g>
Expand Down