Skip to content

Fix throwing of exception on multiple instances #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rokt33r merged 2 commits into from
Oct 10, 2019
Merged

Fix throwing of exception on multiple instances #3243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
762f8b3
Single Instance fix #3241
jhdcruz Sep 5, 2019
6ba1d50
Merge pull request #1 from BoostIO/master
jhdcruz Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions lib/main-app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,23 @@ const ipc = electron.ipcMain
const GhReleases = require('electron-gh-releases')
const { isPackaged } = app
// electron.crashReporter.start()
const singleInstance = app.requestSingleInstanceLock()

var ipcServer = null

var mainWindow = null

var shouldQuit = app.makeSingleInstance(function (commandLine, workingDirectory) {
if (mainWindow) {
if (process.platform === 'win32') {
mainWindow.minimize()
mainWindow.restore()
}
mainWindow.focus()
}
return true
})

if (shouldQuit) {
// Single Instance Lock
if (!singleInstance) {
app.quit()
} else {
app.on('second-instance', () => {
// Someone tried to run a second instance, it should focus the existing instance.
if (mainWindow) {
if (!mainWindow.isVisible()) mainWindow.show()
mainWindow.focus()
}
})
}

var isUpdateReady = false
Expand Down