Skip to content

ignore # in the code block #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asmsuechan merged 4 commits into from
Mar 18, 2017
Merged

ignore # in the code block #324

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
034f467
ignore # in the code block
sosukesuzuki Mar 16, 2017
b577ca2
Refactor the dirty code
sosukesuzuki Mar 17, 2017
fe1c197
reduce indent
sosukesuzuki Mar 17, 2017
806c3bb
delete unnecessary `}` and correct the indent
sosukesuzuki Mar 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions browser/main/Detail/MarkdownNoteDetail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,16 @@ class MarkdownNoteDetail extends React.Component {
findTitle (value) {
let splitted = value.split('\n')
let title = null
let isMarkdownInCode = false

for (let i = 0; i < splitted.length; i++) {
let trimmedLine = splitted[i].trim()
if (trimmedLine.match(/^# .+/)) {
title = trimmedLine.substring(1, trimmedLine.length).trim()
break
if (trimmedLine.match('```')){
isMarkdownInCode = !isMarkdownInCode
} else if (isMarkdownInCode === false && trimmedLine.match(/^# +/)) {
title = trimmedLine.substring(1, trimmedLine.length).trim()
break
}
Copy link
Contributor

@asmsuechan asmsuechan Mar 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can make this if clause better. Like below:

if(markdownInCode === false && trimmendLine.match(/^# +/)){
  title = trimmedLine.substring(1, trimmedLine.length).trim()
  break
}

Copy link
Contributor Author

@sosukesuzuki sosukesuzuki Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting my code. I think that it is readble than my code. I'll rewrite it.

}
Copy link
Contributor

@asmsuechan asmsuechan Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for corrections! And I recognized 1 point. You can reduce 1 indent like this below:

if (trimmedLine.match('```')){
  isMarkdownInCode = !isMarkdownInCode
} else if(isMarkdownInCode === false && trimmedLine.match(/^# +/)) {
  title = trimmedLine.substring(1, trimmedLine.length).trim()
  break
}

Copy link
Contributor Author

@sosukesuzuki sosukesuzuki Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your advice ! I will fix it soon.

}
Copy link
Contributor

@asmsuechan asmsuechan Mar 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code doesn't work. Because there is an extra }. And also the indents are not good 😨

if (trimmedLine.match('```')){
  isMarkdownInCode = !isMarkdownInCode
} else if (isMarkdownInCode === false && trimmedLine.match(/^# +/)) {
  title = trimmedLine.substring(1, trimmedLine.length).trim()
  break
}

Copy link
Contributor Author

@sosukesuzuki sosukesuzuki Mar 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'll fix it soon.


Expand Down