Skip to content

I changed the button deleting snnipet and markdown from ... to trash can. #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asmsuechan merged 3 commits into from
Mar 15, 2017
Merged

I changed the button deleting snnipet and markdown from ... to trash can. #307

asmsuechan merged 3 commits into from
Mar 15, 2017

Conversation

@sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Mar 2, 2017

Before

2017-03-03 02 23 03

After

2017-03-03 02 23 53

@asmsuechan asmsuechan self-requested a review March 4, 2017 22:46
asmsuechan
asmsuechan reviewed Mar 11, 2017
View reviewed changes
Copy link
Contributor

@asmsuechan asmsuechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @sosukesuzuki, could you check this?

browser/SnippetTab.js Outdated
@@ -0,0 +1,131 @@
import React from 'react'
Copy link
Contributor

@asmsuechan asmsuechan Mar 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this is an extra file. You need to remove this.

Copy link
Member Author

@sosukesuzuki sosukesuzuki Mar 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.I had overlooked it. I'll correct it.

browser/main/Detail/MarkdownNoteDetail.js Outdated
<svg height="17px" id="Capa_1" style={{"enableBackground":"new 0 0 753.23 753.23"}} width="17px" version="1.1" viewBox="0 0 753.23 753.23" x="0px" y="0px" xmlSpace="preserve">
<g>
<g id="_x34__19_">
<g>
Copy link
Contributor

@asmsuechan asmsuechan Mar 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indents seem broken.

Copy link
Member Author

@sosukesuzuki sosukesuzuki Mar 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll correct the indents.

asmsuechan
asmsuechan approved these changes Mar 15, 2017
View reviewed changes
Copy link
Contributor

@asmsuechan asmsuechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. LGTM.

@asmsuechan asmsuechan merged commit 3dc1b59 into master Mar 15, 2017
@asmsuechan asmsuechan deleted the feature-trashCan-icon branch March 15, 2017 20:55
@kedzilla
Copy link

kedzilla commented Apr 15, 2017

I have a question here.
When pressed, there is a small popup with the "delete" tag. Then once this is clicked, there is a confirmation menu. If you are asking confirmation, why not go directly to that message instead of having the user clicked on the "delete" popup? Thank you and great app! I am looking forward to learn about electron and maybe contribute one day 👍

@asmsuechan
Copy link
Contributor

asmsuechan commented Apr 15, 2017

Hi, @kedzilla. Thank you for your comment! Actually, I fixed it already in #340 and it's going to be released next update. Check it out 😄
Yeah! Feel free to join our slack team! https://boostnote-group.slack.com/shared_invite/MTY3MzY5Mjc4ODk3LTE0OTE5Njg0NjEtNzg2MzUwOTY3NQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@asmsuechan asmsuechan asmsuechan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sosukesuzuki @kedzilla @asmsuechan