Skip to content

Fix empty link 2 #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rokt33r merged 5 commits into from
May 6, 2019
Merged

Fix empty link 2 #2986

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
533e463
Merge branch 'master' of https://github.com/BoostIO/Boostnote
ZeroX-DG Mar 7, 2019
7c73490
Merge branch 'master' of https://github.com/BoostIO/Boostnote
ZeroX-DG Mar 23, 2019
07fb8c0
Merge branch 'master' of https://github.com/BoostIO/Boostnote
ZeroX-DG Apr 20, 2019
3db3542
Merge branch 'master' of https://github.com/BoostIO/Boostnote
ZeroX-DG May 1, 2019
d53a1e1
fixed open empty link 2
ZeroX-DG May 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser/components/MarkdownPreview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ export default class MarkdownPreview extends React.Component {
return
}
// No contextMenu was passed to us -> execute our own link-opener
if (event.target.tagName.toLowerCase() === 'a') {
if (event.target.tagName.toLowerCase() === 'a' && event.target.getAttribute('href')) {
const href = event.target.href
const isLocalFile = href.startsWith('file:')
if (isLocalFile) {
Expand Down