Skip to content

Issue 2950 - clicking on elements when in full page preview toggles the mode back to split. #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rokt33r merged 5 commits into from
Apr 12, 2019
Merged

Issue 2950 - clicking on elements when in full page preview toggles the mode back to split. #2952

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6f30c3
Merge pull request #1 from BoostIO/master
Mar 4, 2019
d5377bb
Merge pull request #2 from BoostIO/master
Mar 27, 2019
2c409c3
Changes and refactor of HandleMouseDown
Mar 27, 2019
44e39d2
Update MarkdownPreview.js
Mar 27, 2019
744a7bf
Update MarkdownPreview.js
Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions browser/components/MarkdownPreview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,33 +282,27 @@ export default class MarkdownPreview extends React.Component {

handleMouseDown (e) {
const config = ConfigManager.get()
const clickElement = e.target
const targetTag = clickElement.tagName // The direct parent HTML of where was clicked ie "BODY" or "DIV"
const lineNumber = getSourceLineNumberByElement(clickElement) // Line location of element clicked.

if (config.editor.switchPreview === 'RIGHTCLICK' && e.buttons === 2 && config.editor.type === 'SPLIT') {
eventEmitter.emit('topbar:togglemodebutton', 'CODE')
}
if (e.ctrlKey) {
if (config.editor.type === 'SPLIT') {
const clickElement = e.target
const lineNumber = getSourceLineNumberByElement(clickElement)
if (lineNumber !== -1) {
eventEmitter.emit('line:jump', lineNumber)
}
} else {
const clickElement = e.target
const lineNumber = getSourceLineNumberByElement(clickElement)
if (lineNumber !== -1) {
eventEmitter.emit('editor:focus')
eventEmitter.emit('line:jump', lineNumber)
}
}
}
if (e.target != null) {
switch (e.target.tagName) {
case 'A':
case 'INPUT':
return null
}
}
if (this.props.onMouseDown != null) this.props.onMouseDown(e)

if (this.props.onMouseDown != null && targetTag === 'BODY') this.props.onMouseDown(e)
}

handleMouseUp (e) {
Expand Down