Add dataApi.copyImage for copying image to boostnote storage on an image dropped into CodeEditor #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
related: #286 |
asmsuechan
changed the title
Contributor
Author
|
I'm waiting to be merged #298. |
asmsuechan
commented
Feb 21, 2017
browser/components/CodeEditor.js
Outdated
| this.insertImage(imageMd) | ||
|
|
||
| copyImage(imagePath, this.props.storageKey).then((imagePathInTheStorage) => { | ||
| let imageMd = `` |
…age to boostnote storage on an image doropped into CodeEditor
sota1235
reviewed
Mar 19, 2017
| insertImage (imageMd) { | ||
| const textarea = this.editor.getInputField() | ||
| textarea.value = textarea.value.substr(0, textarea.selectionStart) + imageMd + textarea.value.substr(textarea.selectionEnd) | ||
| insertImageMd (imageMd) { |
sota1235
reviewed
Mar 19, 2017
| const textarea = this.editor.getInputField() | ||
| textarea.value = textarea.value.substr(0, textarea.selectionStart) + imageMd + textarea.value.substr(textarea.selectionEnd) | ||
| insertImageMd (imageMd) { | ||
| const cm = this.editor |
Contributor
There was a problem hiding this comment.
What the mean of cm? If it is not popular wording, I want you to explain more detail.
Contributor
Author
There was a problem hiding this comment.
it's CodeMirror and used this name overall of Boostnote.
sota1235
reviewed
Mar 19, 2017
| if (!_.isArray(cachedStorageList)) throw new Error('Target storage doesn\'t exist.') | ||
|
|
||
| const storage = _.find(cachedStorageList, {key: storageKey}) | ||
| if (storage == null) throw new Error('Target storage doesn\'t exist.') |
Contributor
There was a problem hiding this comment.
Can't you use ===?
And maybe, _.find returns undefined.
https://lodash.com/docs/4.17.4#find
So you need to write === undefined.
sota1235
reviewed
Mar 19, 2017
| if (storage == null) throw new Error('Target storage doesn\'t exist.') | ||
| return storage | ||
| } catch (e) { | ||
| return Promise.reject(e) |
Contributor
There was a problem hiding this comment.
Maybe you can write like below.
try {
// Try to get target storage
const targetStorage = 'brabra';
} catch (e) {
// You do not need to try creating 'images' directory
return Promise.reject(e);
}
return new Promise((resolve, reject) => {
// brabra
});
sota1235
suggested changes
Mar 19, 2017
Contributor
sota1235
left a comment
sota1235
left a comment
There was a problem hiding this comment.
Please fix some points.
Contributor
Author
|
@sota1235 I fixed them. |
|
This is going to be a great feature that many people want! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable that to copy an image when it is dropped into CodeEditor. It means the image is kept into boostnote storage:
~/Boostnote/images/imageName.png