Skip to content

[Fix] GIFs don't animate #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 1 commit into from
Feb 4, 2019
Merged

[Fix] GIFs don't animate #2852

Rokt33r merged 1 commit into from
Feb 4, 2019

Conversation

@Aaron-Bird
Copy link
Contributor

@Aaron-Bird Aaron-Bird commented Jan 30, 2019

Description

Before
before

After
after

Issue fixed

Fix gif not playing

Type of changes

  • 🔵 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔵 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔵 All existing tests have been passed
  • 🔵 I have attached a screenshot/video to visualize my change if possible

@Aaron-Bird Aaron-Bird changed the title [fix]GIFs don't animate [Fix] GIFs don't animate Jan 30, 2019
@Rokt33r Rokt33r added the awaiting review ❇️ Pull request is awaiting a review. label Feb 1, 2019
@Rokt33r Rokt33r self-requested a review February 1, 2019 07:42
ZeroX-DG
ZeroX-DG approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 However, I'm thinking of another approach. What if we specify a list of extension to skip the fixRotate so that we can reuse it the future. But currently, I think we only need to skip the fixRotate for GIF so implementing a list of extension seems redundant. @Rokt33r what do you think?

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Feb 1, 2019
@Rokt33r
Copy link
Member

Rokt33r commented Feb 4, 2019

I agree with you. It looks fine for now. Let's do it when we found other formats which should not be fixed.

@Rokt33r Rokt33r removed the needs extra review 🔎 Pull request requires review from an additional reviewer. label Feb 4, 2019
@Rokt33r Rokt33r added this to the v0.11.14 milestone Feb 4, 2019
@Rokt33r Rokt33r merged commit 53ff693 into BoostIO:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees

No one assigned

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Milestone

v0.11.14

Development

Successfully merging this pull request may close these issues.

3 participants

@Aaron-Bird @Rokt33r @ZeroX-DG