Strange url-handling reverted + tests modified so that they might fin…

[ehhc]

Strange url-handling reverted + tests modified so that they might fin…d that issue in the future + test modified so that they both contain tests for posix and windows path separator -> fixes #2834

[ehhc]

the idea of the changes in the tests was that they should test both for posix and windows systems.. obviously that still dosen't work correct (they are green at my maschine since the fist commti -.-)

[daiyam]

The problem with the regex '/?' + STORAGE_FOLDER_PLACEHOLDER + '.*?"' is the usage of the terminator ".

For an image, it generates <img src="<path>", so the path is correctly found.
For a gallery, it generates:

<div class="gallery">
path1
path2
path3
</div>

In that case, the paths won't be found.

[daiyam]

@ehhc, here the fixed regex:

function fixLocalURLS (renderedHTML, storagePath) {
  /*
    A :storage reference is like `:storage/3b6f8bd6-4edd-4b15-96e0-eadc4475b564/f939b2c3.jpg`.

    - `STORAGE_FOLDER_PLACEHOLDER` will match `:storage`
    - `(?:(?:\\\/|%5C)[-.\\w]+)+` will match `/3b6f8bd6-4edd-4b15-96e0-eadc4475b564/f939b2c3.jpg`
    - `(?:\\\/|%5C)[-.\\w]+` will either match `/3b6f8bd6-4edd-4b15-96e0-eadc4475b564` or `/f939b2c3.jpg`
    - `(?:\\\/|%5C)` match the path seperator. `\\\/` for posix systems and `%5C` for windows.
  */
  return renderedHTML.replace(new RegExp('/?' + STORAGE_FOLDER_PLACEHOLDER + '(?:(?:\\\/|%5C)[-.\\w]+)+', 'g'), function (match) {
    var encodedPathSeparators = new RegExp(mdurl.encode(path.win32.sep) + '|' + mdurl.encode(path.posix.sep), 'g')
    return match.replace(encodedPathSeparators, path.sep).replace(new RegExp('/?' + STORAGE_FOLDER_PLACEHOLDER, 'g'), 'file:///' + path.join(storagePath, DESTINATION_FOLDER))
  })
}

I've forgot that the \w doesn't include the -...

Anyway, thanks for the updated tests.

[Rokt33r]

@daiyam @ehhc Is this pr ready? If so, I'll review it today.

[ehhc]

@daiyam can you merge my PR with your fixed regex? So that we have a working attachmentMangement with proper tests again? + can you include tests for your image gallery??

@Rokt33r the PR would fix the attachment problem but would break the gallery... Unfortunately i don't have time to fix both.. but i think @daiyam will? (hopefully..?)

[Rokt33r]

@ehhc Awesome! If @daiyam responses late, I'll try to merge this pr and disable gallery temporarily.

[daiyam]

@Rokt33r go ahead to merge this PR to fix the urgent bug.
I will do another PR with the regex fixed and some tests for the gallery.

[Rokt33r]

@daiyam Okay, then I'll just merge this PR and release again without undoing gallery.

[Rokt33r]

I confirmed that it works on Windows. Btw, I've tried this on macOS and it seems that both v0.11.13 and this pr don't work on macOS.(This should be other problem I think)

@ehhc Do you think you can fix this too?

@ZeroX-DG Could you check that dragging an image to editor works on Linux?

[ZeroX-DG]

Dragging the image into editor works fine for me on Linux both the current version and this PR. Seem that Linux is not affected by this bug.

[ehhc]

@Rokt33r sorry, i cannot fix it for Mac because i don't have one and i have no idea what the problem might be.. Sorry

@Rokt33r are the jest-Tests (yarn jest) working on Mac?

[Rokt33r]

are the jest-Tests (yarn jest) working on Mac?

@ehhc Yeah it works fine.

[ehhc]

@Rokt33r then i have no idea whats wrong on mac.. sorry :(

[daiyam]

@Rokt33r I already have the PR #2642 to fix the issue you are getting 😉

[daiyam]

@ehhc @Rokt33r I've made the PR #2848 to fix the regex