Skip to content

Conversation

@MiloTodt
Copy link
Contributor

@MiloTodt MiloTodt commented Jan 10, 2019

Description

Issue found to be an out of date Katex module, after update these symbols now work.
Updated Katex module from 0.9.0 -> 0.10.0

Issue fixed

fix #2777
$\real$ now working as requested.

image

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

Upgrading Katex module has caused previous test for it to fail.
Suggest updating the markdown-test.js.snap snapshot to reflect the new version of Katex.
The 'vulnerable libraries' that guardrails is objecting to were present in package.json before this change.

@guardrails
Copy link

guardrails bot commented Jan 10, 2019

No more findings on this branch.
This means you fixed everything we detected earlier. Good job!! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

Happy with the results? Give your feedback.

@MiloTodt MiloTodt changed the title Fix #2777 - Improvement request- Problems with some Katex functions Fix #2788 - Improvement request- Problems with some Katex functions Jan 10, 2019
@MiloTodt MiloTodt changed the title Fix #2788 - Improvement request- Problems with some Katex functions Fix #2777 - Improvement request- Problems with some Katex functions Jan 10, 2019
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jan 11, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use yarn instead of npm so please re-install the dependency using yarn

@MiloTodt
Copy link
Contributor Author

Katex 0.10.0 now installed with yarn instead of npm

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 22, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added duplicate 🚫 Issue is a duplicate. and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Jan 22, 2019
@ZeroX-DG
Copy link
Member

I'm really sorry @MiloTodt but there's already a PR before this one: #2576. Thank you for your contribution anyway!

@ZeroX-DG ZeroX-DG closed this Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate 🚫 Issue is a duplicate.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Katex functions not supported

2 participants