[Fix] Issue#2408 #2728

Cesar-Medeiros · 2018-12-19T19:56:45Z

Description

Enabling the user to open folders containing files, or files themselves, created by the application.

Issue fixed

#2408

Type of changes

⚪ Bug fix (Change that fixed an issue)
⚪ Breaking change (Change that can cause existing functionality to change)
⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
🔘 Feature (Change that adds new functionality)
⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

🔘 My code follows the project code style
🔘 I have written test for my code and it has been tested
🔘 All existing tests have been passed
🔘 I have attached a screenshot/video to visualize my change if possible

MargaridaSilva · 2018-12-19T23:45:16Z

We would really appreciate to know whether this PR is ready to be accepted, hence we are working on this open source project in the context of a university course and it would be beneficial to discuss this PR, or even see it being approved.

ZeroX-DG · 2018-12-20T15:03:50Z

@margarida-silva I'll review and approve this PR soon for your uni course so if you can provide me with more information about this PR I'll be able to speed up the review process. I don't know how much time you can wait for this PR to be approved so please don't hesitate to tell me if you need this PR to be reviewed faster.

Cesar-Medeiros · 2018-12-27T17:13:22Z

@ZeroX-DG Thanks for your reply. In this PR we added the functionality of opening a file instead of just importing it. Each time a file is opened by clicking on "Open File" we can change the note in boostnote and the original file is also modified. The same happens if we edit the original file, the note will be modified in boostnote. The gif attached in the main post helps to understand this PR.

Thanks for speeding up the review process.

ZeroX-DG

This is a nice feature to have. Please update your code 👍 I'll try to finish reviewing this before new year 😄

ZeroX-DG · 2018-12-29T06:38:26Z

browser/main/NoteList/index.js

    const note = this.notes[0]
    const prevKey = prevProps.location.query.key
    const noteKey = visibleNoteKeys.includes(prevKey) ? prevKey : note && note.key
+    const CSON = require('@rokt33r/season')


Can you move this to the top of the file?

ZeroX-DG · 2018-12-29T06:40:31Z

browser/main/NoteList/index.js

+      if (focusNote.filepath !== undefined) {
+        try {
+          this.fsWatcher.close()
+        } catch (e) {


Please at least console.error the error. It might come in handy in the future.

ZeroX-DG · 2018-12-29T06:41:55Z

browser/main/NoteList/index.js

+
+            case 'rename':
+              updatedNote.filepath = undefined
+              this.fsWatcher.close()


Why did you have to catch for errors in the previous line 150 and not here?

I forgot to add exception handling. I just updated the code with all suggestions.

ZeroX-DG · 2019-01-04T15:46:04Z

Please fix the conflict and also I encounter this error when I run the app.

ZeroX-DG · 2019-01-06T03:05:57Z

I'm sorry @Cesar-Medeiros, this is the PR that causing the bug above: #2768, please merge the master branch again to fix this bug. Also, I found 2 bugs related to your PR.

First bug: When I add a new file, the highlight for that note is wrong. Demo:

Second bug: After I added that new file, I tried to update its' content using Boostnote and then using external editor. After that I switch to a new note and the app crashed and this error printed in the terminal (This is probably a Linux related bug):

Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
/home/zerox/Desktop/Projects/Boostnote/node_modules/electron/dist/electron --type=renderer --no-sandb[8119]: ../../vendor/node/src/fs_event_wrap.cc:91:static void node::(anonymous namespace)::FSEventWrap::GetInitialized(const FunctionCallbackInfo<v8::Value> &): Assertion `wrap != nullptr' failed.
 1: node::Abort() [/home/zerox/Desktop/Projects/Boostnote/node_modules/electron/dist/libnode.so]
 2: 0x7f347fd4a422 [/home/zerox/Desktop/Projects/Boostnote/node_modules/electron/dist/libnode.so]
 3: 0x7f347fd3f5fa [/home/zerox/Desktop/Projects/Boostnote/node_modules/electron/dist/libnode.so]
 4: 0x295cd9c07841

Cesar-Medeiros · 2019-01-06T17:56:18Z

I will try to fix this bugs as soon as possible.
Thank you.

guardrails · 2019-01-17T13:37:57Z

No more findings on this branch.
This means you fixed everything we detected earlier. Good job!! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

Happy with the results? Give your feedback.

[Fix] FSWatcher close bug

Cesar-Medeiros · 2019-01-17T15:46:10Z

@ZeroX-DG I believe I have fixed both bugs.
We deeply appreciate your concern on reviewing this PR as soon as possible.
Regarding the university course context, we would also be pleased to hear from you about another issue we've attempted to fix (#2702).

ZeroX-DG · 2019-01-19T08:45:40Z

@Cesar-Medeiros Editing in Boostnote update the file content works fine but now when I edit the note using an external app, it won't update in Boostnote, sometimes the app crashed and the second bug appears. Also, when I rename the file and switch to other note before switching back to that note, the app carshed and again the second bug appears.

Cesar-Medeiros · 2019-01-19T12:29:39Z

@ZeroX-DG Thank you for your feedback.
Which text editor are you using to edit the note?

ZeroX-DG · 2019-01-20T08:49:40Z

The problem seems to occur only when I edit with Linux gedit app. I used Typora to edit the file and it works fine.

ZeroX-DG · 2020-05-07T13:24:52Z

@Cesar-Medeiros do you still interested in this PR or should I close it?

Cesar-Medeiros · 2020-05-07T14:36:03Z

@ZeroX-DG, Our team is no longer working on this issue. You can close it.

ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Dec 20, 2018

ZeroX-DG reviewed Dec 29, 2018

View reviewed changes

Cesar-Medeiros added 6 commits January 17, 2019 13:29

[Add] Open file

0c1f4e2

[Code Styling] Correction

2212a6e

[Fix] Minor bug fix

6bc3a18

[Add] Update reference file test

e8a0618

[Style] Correction

c63b33a

[Add] Code suggestions

e797d56

Cesar-Medeiros force-pushed the master branch from 557fd87 to e797d56 Compare January 17, 2019 13:46

[Add] Focus note feature

a93a6e4

[Fix] FSWatcher close bug

ZeroX-DG closed this May 7, 2020

Uh oh!

[Fix] Issue#2408 #2728

[Fix] Issue#2408 #2728

Uh oh!

Conversation

Cesar-Medeiros commented Dec 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue fixed

Type of changes

Checklist:

Uh oh!

MargaridaSilva commented Dec 19, 2018

Uh oh!

ZeroX-DG commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Cesar-Medeiros commented Dec 27, 2018

Uh oh!

ZeroX-DG left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZeroX-DG Dec 29, 2018

Choose a reason for hiding this comment

Uh oh!

ZeroX-DG Dec 29, 2018

Choose a reason for hiding this comment

Uh oh!

ZeroX-DG Dec 29, 2018

Choose a reason for hiding this comment

Uh oh!

Cesar-Medeiros Dec 30, 2018

Choose a reason for hiding this comment

Uh oh!

ZeroX-DG commented Jan 4, 2019

Uh oh!

ZeroX-DG commented Jan 6, 2019

Uh oh!

Cesar-Medeiros commented Jan 6, 2019

Uh oh!

guardrails bot commented Jan 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Cesar-Medeiros commented Jan 17, 2019

Uh oh!

ZeroX-DG commented Jan 19, 2019

Uh oh!

Cesar-Medeiros commented Jan 19, 2019

Uh oh!

ZeroX-DG commented Jan 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZeroX-DG commented May 7, 2020

Uh oh!

Cesar-Medeiros commented May 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Cesar-Medeiros commented Dec 19, 2018 •

edited

Loading

ZeroX-DG commented Dec 20, 2018 •

edited

Loading

ZeroX-DG left a comment •

edited

Loading

guardrails bot commented Jan 17, 2019 •

edited

Loading

ZeroX-DG commented Jan 20, 2019 •

edited

Loading