Skip to content

Conversation

@SofiaCardosoMartins
Copy link

Description

In a previous version, the single-line code block appeared with a dark font color, which made it difficult to be noticed. With this changes, the font color was changed to red without it interfering with the multi-line code block theme which is defined in the preferences menu.

issue_1994

Issue fixed

The applied changes were made only in the CSS code, adding new selectors, to distinguish between the single-line and the multi-line code blocks.

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • 🔘 Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Dec 21, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Feb 1, 2020

@SofiaCardosoMartins Sorry for the wait, I was quite busy these days, I think the red color looks strange in dark theme. Can you create custom color for each theme?
https://github.com/BoostIO/Boostnote/blob/8218d5eb5a4b60bdb2b650d32ac1b3abea048e28/browser/components/markdown.styl#L502-L517
If you can do that then we can fix this issue too: #2373

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Feb 1, 2020
@ZeroX-DG
Copy link
Member

ZeroX-DG commented May 4, 2020

Fixed in #3473

@ZeroX-DG ZeroX-DG closed this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants