Fixed duplicate TOC Title jump error #2592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyaxu
force-pushed
the
bug-2581
branch
2 times, most recently
from
c3a0483 to
8298e38
Compare
Member
|
@enyaxu your snapshot tests is failing, can you fix it? |
Contributor
Author
|
Ok, I checked these errors.fix it need to update Ava snapshots.
Nguyen Viet Hung <[email protected]>于2018年11月10日 周六下午6:55写道：
… @enyaxu <https://github.com/enyaxu> your snapshot tests is failing, can
you fix it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2592 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AmfiSCUnlA-y7zkNuQnorTj9fR72fQ96ks5utrCkgaJpZM4YX3EK>
.
|
Contributor
Author
|
@ZeroX-DG I fixed the checks errors. Please review. |
ZeroX-DG
approved these changes
Nov 14, 2018
Member
ZeroX-DG
left a comment
ZeroX-DG
left a comment
There was a problem hiding this comment.
LGTM 🎉 Thank you for your contribution
ZeroX-DG
added
approved 👍
Rokt33r
added
next release (v0.11.12)
and removed
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug describe in issue #2581.